OpenSlides/openslides/agenda/views.py

514 lines
19 KiB
Python
Raw Normal View History

import jsonschema
from django.contrib.auth import get_user_model
2015-12-19 00:29:20 +01:00
from django.db import transaction
2019-06-03 17:04:30 +02:00
from django.db.utils import IntegrityError
2012-02-20 17:46:45 +01:00
from openslides.core.config import config
2016-12-06 12:21:29 +01:00
from openslides.utils.autoupdate import inform_changed_data
from openslides.utils.exceptions import OpenSlidesError
from openslides.utils.rest_api import (
GenericViewSet,
ListModelMixin,
ModelViewSet,
Response,
RetrieveModelMixin,
UpdateModelMixin,
ValidationError,
detail_route,
list_route,
2019-06-03 17:04:30 +02:00
status,
)
Replaces the old `angular2tree` with a custom drag&drop tree Calculates the direction of the moving. Finishes the moving of nodes in same level Adds some style Sets the padding dynamically Adds placeholder depends on the horizontal movement Set the placeholder at the correct place, so the user can see, where he will drop the moved node Finishes moving of nodes - Old parents change their option to expand. - New parents change their option to expand. - If the user moves a node between nodes with a higher level, the node will be moved to the next index with same or lower level. Fixes the visibility of moved node - If the new parent is not visible, the moved node will not be seen. If the user moves an expanded node, the new parent should expanded, too, if it's not already. Sending successfully data to the server - Sorting the items Handles moving nodes between parent and children - If the user moves a node between a parent and its children, the children will be relinked to the moved node as their new parent. Replaces the old `sorting-tree` to a new one - The new `sorted-tree` replaces the old `sorting-tree`. - The old package `angular-tree-component` was removed. - The user will only see the buttons to save or cancel his changes, if he made changes. - The buttons, that do not work currently, were removed. Adds a guard to check if the user made changes. - If the user made changes but he has not saved them, then there is a dialog that will prompt to ask for confirmation. Before cancelling the changes the user has to confirm this.
2019-02-22 12:04:36 +01:00
from openslides.utils.views import TreeSortMixin
from ..utils.auth import has_perm
2019-06-03 17:04:30 +02:00
from ..utils.utils import get_model_from_collection_string
from .access_permissions import ItemAccessPermissions
from .models import Item, ListOfSpeakers, Speaker
2012-02-20 17:46:45 +01:00
# Viewsets for the REST API
2013-02-16 10:41:22 +01:00
2019-01-06 16:22:33 +01:00
class ItemViewSet(ModelViewSet, TreeSortMixin):
"""
API endpoint for agenda items.
There are some views, see check_view_permissions.
"""
2019-01-06 16:22:33 +01:00
access_permissions = ItemAccessPermissions()
queryset = Item.objects.all()
def check_view_permissions(self):
"""
Returns True if the user has required permissions.
"""
if self.action in ("list", "retrieve", "metadata"):
result = self.get_access_permissions().check_permissions(self.request.user)
2019-06-03 17:04:30 +02:00
elif self.action in (
"partial_update",
"update",
"destroy",
"sort",
"assign",
"create",
):
2019-01-06 16:22:33 +01:00
result = (
has_perm(self.request.user, "agenda.can_see")
and has_perm(self.request.user, "agenda.can_see_internal_items")
and has_perm(self.request.user, "agenda.can_manage")
)
elif self.action in ("numbering",):
result = has_perm(self.request.user, "agenda.can_see") and has_perm(
self.request.user, "agenda.can_manage"
)
else:
result = False
return result
2019-06-03 17:04:30 +02:00
def create(self, request, *args, **kwargs):
"""
Creates an agenda item and adds the content object to the agenda.
Request args should specify the content object:
{
"collection": <The collection string>,
"id": <The content object id>
}
"""
collection = request.data.get("collection")
id = request.data.get("id")
if not isinstance(collection, str):
raise ValidationError({"detail": "The collection needs to be a string"})
if not isinstance(id, int):
raise ValidationError({"detail": "The id needs to be an int"})
try:
model = get_model_from_collection_string(collection)
except ValueError:
raise ValidationError("Invalid collection")
try:
content_object = model.objects.get(pk=id)
except model.DoesNotExist:
raise ValidationError({"detail": "The id is invalid"})
if not hasattr(content_object, "get_agenda_title_information"):
raise ValidationError(
{"detail": "The collection does not have agenda items"}
)
try:
item = Item.objects.create(content_object=content_object)
except IntegrityError:
raise ValidationError({"detail": "The item is already in the agenda"})
inform_changed_data(content_object)
return Response({id: item.id})
def destroy(self, request, *args, **kwargs):
"""
Removes the item from the agenda. This does not delete the content
object. Also, the deletion is denied for items with topics as content objects.
"""
item = self.get_object()
content_object = item.content_object
if content_object.get_collection_string() == "topics/topic":
raise ValidationError(
{"detail": "You cannot delete the agenda item to a topic"}
)
item.delete()
inform_changed_data(content_object)
return Response(status=status.HTTP_204_NO_CONTENT)
def update(self, *args, **kwargs):
"""
2018-10-15 21:25:41 +02:00
Customized view endpoint to update all children if the item type has changed.
We do not check the level (affected by changing the parent) in fact that this
change is currentl only done via the sort view.
"""
old_type = self.get_object().type
2018-10-15 21:25:41 +02:00
response = super().update(*args, **kwargs)
2018-10-15 21:25:41 +02:00
# Update all children if the item type has changed.
item = self.get_object()
if old_type != item.type:
items_to_update = []
2018-10-15 21:25:41 +02:00
# Recursively add children to items_to_update.
def add_item(item):
items_to_update.append(item)
for child in item.children.all():
add_item(child)
add_item(item)
inform_changed_data(items_to_update)
2018-10-15 21:25:41 +02:00
return response
@list_route(methods=["post"])
def numbering(self, request):
"""
Auto numbering of the agenda according to the config. Manually added
item numbers will be overwritten.
"""
if not config["agenda_enable_numbering"]:
raise ValidationError(
{"detail": "Numbering of agenda items is deactivated."}
)
Item.objects.number_all(numeral_system=config["agenda_numeral_system"])
return Response({"detail": "The agenda has been numbered."})
@list_route(methods=["post"])
def sort(self, request):
"""
Sorts the whole agenda represented in a tree of ids. The request data should be a list (the root)
of all main agenda items. Each node is a dict with an id and optional children:
{
id: <the id>
children: [
<children, optional>
]
}
Every id has to be given.
"""
return self.sort_tree(request, Item, "weight", "parent_id")
@list_route(methods=["post"])
@transaction.atomic
def assign(self, request):
"""
Assign multiple agenda items to a new parent item.
Send POST {... see schema ...} to assign the new parent.
This aslo checks the parent field to prevent hierarchical loops.
"""
schema = {
"$schema": "http://json-schema.org/draft-07/schema#",
"title": "Agenda items assign new parent schema",
"description": "An object containing an array of agenda item ids and the new parent id the items should be assigned to.",
"type": "object",
"propterties": {
"items": {
"description": "An array of agenda item ids where the items should be assigned to the new parent id.",
"type": "array",
"items": {"type": "integer"},
"minItems": 1,
"uniqueItems": True,
},
"parent_id": {
"description": "The agenda item id of the new parent item.",
"type": "integer",
},
},
"required": ["items", "parent_id"],
}
# Validate request data.
try:
jsonschema.validate(request.data, schema)
except jsonschema.ValidationError as err:
raise ValidationError({"detail": str(err)})
# Check parent item
try:
parent = Item.objects.get(pk=request.data["parent_id"])
except Item.DoesNotExist:
raise ValidationError(
{"detail": f"Parent item {request.data['parent_id']} does not exist"}
)
# Collect ancestors
ancestors = [parent.pk]
grandparent = parent.parent
while grandparent is not None:
ancestors.append(grandparent.pk)
grandparent = grandparent.parent
# First validate all items before changeing them.
items = []
for item_id in request.data["items"]:
# Prevent hierarchical loops.
if item_id in ancestors:
raise ValidationError(
{
"detail": f"Assigning item {item_id} to one of its children is not possible."
}
)
# Check every item
try:
items.append(Item.objects.get(pk=item_id))
except Item.DoesNotExist:
raise ValidationError({"detail": f"Item {item_id} does not exist"})
# OK, assign new parents.
for item in items:
# Assign new parent.
item.parent = parent
item.save(skip_autoupdate=True)
# Now inform all clients.
inform_changed_data(items)
# Send response.
return Response({"detail": f"{len(items)} items successfully assigned."})
class ListOfSpeakersViewSet(
ListModelMixin, RetrieveModelMixin, UpdateModelMixin, TreeSortMixin, GenericViewSet
):
"""
API endpoint for agenda items.
There are some views, see check_view_permissions.
"""
access_permissions = ItemAccessPermissions()
queryset = ListOfSpeakers.objects.all()
def check_view_permissions(self):
"""
Returns True if the user has required permissions.
"""
if self.action in ("list", "retrieve", "metadata"):
result = self.get_access_permissions().check_permissions(self.request.user)
elif self.action in ("manage_speaker",):
result = has_perm(self.request.user, "agenda.can_see_list_of_speakers")
# For manage_speaker requests the rest of the check is
# done in the specific method. See below.
elif self.action in ("update", "partial_update", "speak", "sort_speakers"):
result = has_perm(
self.request.user, "agenda.can_see_list_of_speakers"
) and has_perm(self.request.user, "agenda.can_manage_list_of_speakers")
else:
result = False
return result
2019-01-06 16:22:33 +01:00
@detail_route(methods=["POST", "PATCH", "DELETE"])
def manage_speaker(self, request, pk=None):
"""
Special view endpoint to add users to the list of speakers or remove
them. Send POST {'user': <user_id>} to add a new speaker. Omit
data to add yourself. Send DELETE {'speaker': <speaker_id>} or
DELETE {'speaker': [<speaker_id>, <speaker_id>, ...]} to remove one or
more speakers from the list of speakers. Omit data to remove yourself.
2018-02-06 14:52:47 +01:00
Send PATCH {'user': <user_id>, 'marked': <bool>} to mark the speaker.
Checks also whether the requesting user can do this. He needs at
least the permissions 'agenda.can_see_list_of_speakers' (see
self.check_view_permissions()). In case of adding himself the
permission 'agenda.can_be_speaker' is required. In case of adding
or removing someone else the permission 'agenda.can_manage_list_of_speakers'
is required. In case of removing himself no other permission is required.
"""
# Retrieve list of speakers.
list_of_speakers = self.get_object()
if request.method == "POST": # Add new speaker
# Retrieve user_id
2019-01-06 16:22:33 +01:00
user_id = request.data.get("user")
# Check permissions and other conditions. Get user instance.
if user_id is None:
# Add oneself
2019-01-06 16:22:33 +01:00
if not has_perm(self.request.user, "agenda.can_be_speaker"):
self.permission_denied(request)
if list_of_speakers.closed:
2019-01-12 23:01:42 +01:00
raise ValidationError({"detail": "The list of speakers is closed."})
user = self.request.user
else:
# Add someone else.
2019-01-06 16:22:33 +01:00
if not has_perm(
self.request.user, "agenda.can_manage_list_of_speakers"
):
self.permission_denied(request)
try:
user = get_user_model().objects.get(pk=int(user_id))
except (ValueError, get_user_model().DoesNotExist):
2019-01-12 23:01:42 +01:00
raise ValidationError({"detail": "User does not exist."})
# Try to add the user. This ensurse that a user is not twice in the
# list of coming speakers.
try:
Speaker.objects.add(user, list_of_speakers)
except OpenSlidesError as e:
2019-01-06 16:22:33 +01:00
raise ValidationError({"detail": str(e)})
# Send new speaker via autoupdate because users without permission
# to see users may not have it but can get it now.
inform_changed_data([user])
# TODO: inform_changed_data(user) should work. But isinstance(user, Iterable) is true...
2018-02-06 14:52:47 +01:00
# Toggle 'marked' for the speaker
2019-01-06 16:22:33 +01:00
elif request.method == "PATCH":
2018-02-06 14:52:47 +01:00
# Check permissions
2019-01-06 16:22:33 +01:00
if not has_perm(self.request.user, "agenda.can_manage_list_of_speakers"):
2018-02-06 14:52:47 +01:00
self.permission_denied(request)
# Retrieve user_id
2019-01-06 16:22:33 +01:00
user_id = request.data.get("user")
2018-02-06 14:52:47 +01:00
try:
user = get_user_model().objects.get(pk=int(user_id))
except (ValueError, get_user_model().DoesNotExist):
2019-01-12 23:01:42 +01:00
raise ValidationError({"detail": "User does not exist."})
2018-02-06 14:52:47 +01:00
2019-01-06 16:22:33 +01:00
marked = request.data.get("marked")
2018-02-06 14:52:47 +01:00
if not isinstance(marked, bool):
2019-01-12 23:01:42 +01:00
raise ValidationError({"detail": "Marked has to be a bool."})
2018-02-06 14:52:47 +01:00
queryset = Speaker.objects.filter(
list_of_speakers=list_of_speakers, user=user, begin_time=None
)
2018-02-06 14:52:47 +01:00
try:
# We assume that there aren't multiple entries for speakers that
# did not yet begin to speak, because this
2018-02-06 14:52:47 +01:00
# is forbidden by the Manager's add method. We assume that
# there is only one speaker instance or none.
speaker = queryset.get()
except Speaker.DoesNotExist:
2019-01-06 16:22:33 +01:00
raise ValidationError(
2019-01-12 23:01:42 +01:00
{"detail": "The user is not in the list of speakers."}
2019-01-06 16:22:33 +01:00
)
2018-02-06 14:52:47 +01:00
else:
speaker.marked = marked
speaker.save()
else:
# request.method == 'DELETE'
2019-01-06 16:22:33 +01:00
speaker_ids = request.data.get("speaker")
# Check permissions and other conditions. Get speaker instance.
if speaker_ids is None:
# Remove oneself
queryset = Speaker.objects.filter(
list_of_speakers=list_of_speakers, user=self.request.user
2019-01-06 16:22:33 +01:00
).exclude(weight=None)
try:
# We assume that there aren't multiple entries because this
# is forbidden by the Manager's add method. We assume that
# there is only one speaker instance or none.
speaker = queryset.get()
except Speaker.DoesNotExist:
2019-01-06 16:22:33 +01:00
raise ValidationError(
2019-01-12 23:01:42 +01:00
{"detail": "You are not on the list of speakers."}
2019-01-06 16:22:33 +01:00
)
else:
speaker.delete()
else:
# Remove someone else.
2019-01-06 16:22:33 +01:00
if not has_perm(
self.request.user, "agenda.can_manage_list_of_speakers"
):
self.permission_denied(request)
2019-01-12 23:01:42 +01:00
if isinstance(speaker_ids, int):
speaker_ids = [speaker_ids]
deleted_speaker_count = 0
for speaker_id in speaker_ids:
try:
speaker = Speaker.objects.get(pk=int(speaker_id))
except (ValueError, Speaker.DoesNotExist):
pass
else:
2017-03-21 11:06:05 +01:00
speaker.delete(skip_autoupdate=True)
deleted_speaker_count += 1
2017-03-21 11:06:05 +01:00
# send autoupdate if speakers are deleted
if deleted_speaker_count > 0:
inform_changed_data(list_of_speakers)
2017-03-21 11:06:05 +01:00
2019-01-12 23:01:42 +01:00
return Response()
2015-05-27 15:42:32 +02:00
2019-01-06 16:22:33 +01:00
@detail_route(methods=["PUT", "DELETE"])
2015-05-27 15:42:32 +02:00
def speak(self, request, pk=None):
"""
Special view endpoint to begin and end speech of speakers. Send PUT
{'speaker': <speaker_id>} to begin speech. Omit data to begin speech of
the next speaker. Send DELETE to end speech of current speaker.
2015-05-27 15:42:32 +02:00
"""
# Retrieve list_of_speakers.
list_of_speakers = self.get_object()
2015-05-27 15:42:32 +02:00
2019-01-06 16:22:33 +01:00
if request.method == "PUT":
2015-05-27 15:42:32 +02:00
# Retrieve speaker_id
2019-01-06 16:22:33 +01:00
speaker_id = request.data.get("speaker")
2015-05-27 15:42:32 +02:00
if speaker_id is None:
speaker = list_of_speakers.get_next_speaker()
2015-05-27 15:42:32 +02:00
if speaker is None:
2019-01-12 23:01:42 +01:00
raise ValidationError({"detail": "The list of speakers is empty."})
2015-05-27 15:42:32 +02:00
else:
try:
speaker = Speaker.objects.get(pk=int(speaker_id))
except (ValueError, Speaker.DoesNotExist):
2019-01-12 23:01:42 +01:00
raise ValidationError({"detail": "Speaker does not exist."})
speaker.begin_speech()
2019-01-12 23:01:42 +01:00
message = "User is now speaking."
2015-05-27 15:42:32 +02:00
else:
# request.method == 'DELETE'
try:
# We assume that there aren't multiple entries because this
# is forbidden by the Model's begin_speech method. We assume that
2015-05-27 15:42:32 +02:00
# there is only one speaker instance or none.
2019-01-06 16:22:33 +01:00
current_speaker = (
Speaker.objects.filter(
list_of_speakers=list_of_speakers, end_time=None
)
2019-01-06 16:22:33 +01:00
.exclude(begin_time=None)
.get()
)
2015-05-27 15:42:32 +02:00
except Speaker.DoesNotExist:
raise ValidationError(
2019-01-06 16:22:33 +01:00
{
"detail": f"There is no one speaking at the moment according to {list_of_speakers}."
2019-01-06 16:22:33 +01:00
}
)
current_speaker.end_speech()
2019-01-12 23:01:42 +01:00
message = "The speech is finished now."
# Initiate response.
2019-01-06 16:22:33 +01:00
return Response({"detail": message})
2019-01-06 16:22:33 +01:00
@detail_route(methods=["POST"])
2016-01-08 23:32:29 +01:00
def sort_speakers(self, request, pk=None):
"""
Special view endpoint to sort the list of speakers.
Expects a list of IDs of the speakers.
"""
# Retrieve list_of_speakers.
list_of_speakers = self.get_object()
2016-01-08 23:32:29 +01:00
# Check data
2019-01-06 16:22:33 +01:00
speaker_ids = request.data.get("speakers")
2016-01-08 23:32:29 +01:00
if not isinstance(speaker_ids, list):
2019-01-12 23:01:42 +01:00
raise ValidationError({"detail": "Invalid data."})
2016-01-08 23:32:29 +01:00
# Get all speakers
speakers = {}
for speaker in list_of_speakers.speakers.filter(begin_time=None):
2016-01-08 23:32:29 +01:00
speakers[speaker.pk] = speaker
2015-12-19 00:29:20 +01:00
# Check and sort speakers
valid_speakers = []
2016-01-08 23:32:29 +01:00
for speaker_id in speaker_ids:
2015-12-19 00:29:20 +01:00
if not isinstance(speaker_id, int) or speakers.get(speaker_id) is None:
2019-01-12 23:01:42 +01:00
raise ValidationError({"detail": "Invalid data."})
2015-12-19 00:29:20 +01:00
valid_speakers.append(speakers[speaker_id])
2019-07-17 16:13:49 +02:00
weight = 1
2015-12-19 00:29:20 +01:00
with transaction.atomic():
for speaker in valid_speakers:
speaker.weight = weight
2016-12-06 12:21:29 +01:00
speaker.save(skip_autoupdate=True)
2015-12-19 00:29:20 +01:00
weight += 1
2016-01-08 23:32:29 +01:00
2016-12-06 12:21:29 +01:00
# send autoupdate
inform_changed_data(list_of_speakers)
2016-12-06 12:21:29 +01:00
2016-01-08 23:32:29 +01:00
# Initiate response.
2019-01-12 23:01:42 +01:00
return Response({"detail": "List of speakers successfully sorted."})