OpenSlides/tests/integration/agenda/test_viewset.py

496 lines
19 KiB
Python
Raw Normal View History

import pytest
from django.contrib.auth import get_user_model
from django.contrib.auth.models import Permission
from django.urls import reverse
from rest_framework import status
from rest_framework.test import APIClient
from openslides.agenda.models import Item, Speaker
from openslides.assignments.models import Assignment
from openslides.core.config import config
from openslides.core.models import Countdown
from openslides.motions.models import Motion
from openslides.topics.models import Topic
2018-09-01 08:00:00 +02:00
from openslides.users.models import Group
from openslides.utils.autoupdate import inform_changed_data
from openslides.utils.test import TestCase
from ..helpers import count_queries
class ContentObjects(TestCase):
"""
Tests content objects with Topic as a content object.
Asserts, that it is recognizes as a content object and tests creation
and deletion of it and the related agenda item.
"""
def setUp(self):
self.client = APIClient()
self.client.login(username="admin", password="admin")
def test_topic_is_content_object(self):
assert hasattr(Topic(), "get_agenda_title_information")
def test_create_content_object(self):
topic = Topic.objects.create(title="test_title_fk3Oc209JDiunw2!wwoH")
assert topic.agenda_item is not None
response = self.client.get(reverse("item-detail", args=[topic.agenda_item.pk]))
self.assertEqual(response.status_code, status.HTTP_200_OK)
def test_delete_content_object(self):
topic = Topic.objects.create(title="test_title_lwOCK32jZGFb37DpmoP(")
item_id = topic.agenda_item.id
topic.delete()
response = self.client.get(reverse("item-detail", args=[item_id]))
self.assertEqual(response.status_code, status.HTTP_404_NOT_FOUND)
class RetrieveItem(TestCase):
"""
Tests retrieving items.
"""
2019-01-06 16:22:33 +01:00
def setUp(self):
self.client = APIClient()
2019-01-06 16:22:33 +01:00
config["general_system_enable_anonymous"] = True
self.item = Topic.objects.create(
title="test_title_Idais2pheepeiz5uph1c"
).agenda_item
def test_normal_by_anonymous_without_perm_to_see_internal_items(self):
2019-01-06 16:22:33 +01:00
group = get_user_model().groups.field.related_model.objects.get(
pk=1
) # Group with pk 1 is for anonymous users.
permission_string = "agenda.can_see_internal_items"
app_label, codename = permission_string.split(".")
permission = group.permissions.get(
content_type__app_label=app_label, codename=codename
)
group.permissions.remove(permission)
self.item.type = Item.AGENDA_ITEM
self.item.save()
2019-01-06 16:22:33 +01:00
response = self.client.get(reverse("item-detail", args=[self.item.pk]))
self.assertEqual(response.status_code, status.HTTP_200_OK)
def test_hidden_by_anonymous_without_manage_perms(self):
2019-01-06 16:22:33 +01:00
response = self.client.get(reverse("item-detail", args=[self.item.pk]))
self.assertEqual(response.status_code, 404)
def test_hidden_by_anonymous_with_manage_perms(self):
2018-09-01 08:00:00 +02:00
group = Group.objects.get(pk=1) # Group with pk 1 is for anonymous users.
2019-01-06 16:22:33 +01:00
permission_string = "agenda.can_manage"
app_label, codename = permission_string.split(".")
permission = Permission.objects.get(
content_type__app_label=app_label, codename=codename
)
group.permissions.add(permission)
2018-09-01 08:00:00 +02:00
inform_changed_data(group)
2019-01-06 16:22:33 +01:00
response = self.client.get(reverse("item-detail", args=[self.item.pk]))
self.assertEqual(response.status_code, status.HTTP_200_OK)
def test_internal_by_anonymous_without_perm_to_see_internal_items(self):
2018-09-01 08:00:00 +02:00
group = Group.objects.get(pk=1) # Group with pk 1 is for anonymous users.
2019-01-06 16:22:33 +01:00
permission_string = "agenda.can_see_internal_items"
app_label, codename = permission_string.split(".")
permission = group.permissions.get(
content_type__app_label=app_label, codename=codename
)
group.permissions.remove(permission)
2018-09-01 08:00:00 +02:00
inform_changed_data(group)
self.item.type = Item.INTERNAL_ITEM
self.item.save()
2019-01-06 16:22:33 +01:00
response = self.client.get(reverse("item-detail", args=[self.item.pk]))
self.assertEqual(response.status_code, status.HTTP_200_OK)
2019-01-06 16:22:33 +01:00
self.assertEqual(
sorted(response.data.keys()),
sorted(
2019-02-15 12:17:08 +01:00
(
"id",
"title_information",
"speakers",
"speaker_list_closed",
"content_object",
)
2019-01-06 16:22:33 +01:00
),
)
forbidden_keys = (
2019-01-06 16:22:33 +01:00
"item_number",
"title_with_type",
"comment",
"closed",
"type",
"is_internal",
"is_hidden",
"duration",
"weight",
"parent",
)
for key in forbidden_keys:
self.assertFalse(key in response.data.keys())
def test_normal_by_anonymous_cant_see_agenda_comments(self):
self.item.type = Item.AGENDA_ITEM
2019-01-06 16:22:33 +01:00
self.item.comment = "comment_gbiejd67gkbmsogh8374jf$kd"
self.item.save()
2019-01-06 16:22:33 +01:00
response = self.client.get(reverse("item-detail", args=[self.item.pk]))
self.assertEqual(response.status_code, status.HTTP_200_OK)
2019-01-06 16:22:33 +01:00
self.assertTrue(response.data.get("comment") is None)
@pytest.mark.django_db(transaction=False)
def test_agenda_item_db_queries():
"""
Tests that only the following db queries are done:
* 1 requests to get the list of all agenda items,
* 1 request to get all speakers,
* 3 requests to get the assignments, motions and topics and
* 1 request to get an agenda item (why?)
TODO: The last three request are a bug.
"""
for index in range(10):
2019-01-12 23:01:42 +01:00
Topic.objects.create(title=f"topic{index}")
2019-01-06 16:22:33 +01:00
parent = Topic.objects.create(title="parent").agenda_item
child = Topic.objects.create(title="child").agenda_item
child.parent = parent
child.save()
2019-01-06 16:22:33 +01:00
Motion.objects.create(title="motion1")
Motion.objects.create(title="motion2")
Assignment.objects.create(title="assignment", open_posts=5)
assert count_queries(Item.get_elements) == 6
class ManageSpeaker(TestCase):
"""
Tests managing speakers.
"""
2019-01-06 16:22:33 +01:00
def setUp(self):
self.client = APIClient()
2019-01-06 16:22:33 +01:00
self.client.login(username="admin", password="admin")
2019-01-06 16:22:33 +01:00
self.item = Topic.objects.create(
title="test_title_aZaedij4gohn5eeQu8fe"
).agenda_item
self.user = get_user_model().objects.create_user(
2019-01-06 16:22:33 +01:00
username="test_user_jooSaex1bo5ooPhuphae",
password="test_password_e6paev4zeeh9n",
)
def test_add_oneself(self):
2019-01-06 16:22:33 +01:00
response = self.client.post(reverse("item-manage-speaker", args=[self.item.pk]))
self.assertEqual(response.status_code, 200)
self.assertTrue(Speaker.objects.all().exists())
def test_add_oneself_twice(self):
2019-01-06 16:22:33 +01:00
Speaker.objects.add(get_user_model().objects.get(username="admin"), self.item)
response = self.client.post(reverse("item-manage-speaker", args=[self.item.pk]))
self.assertEqual(response.status_code, 400)
def test_add_oneself_when_closed(self):
self.item.speaker_list_closed = True
self.item.save()
2019-01-06 16:22:33 +01:00
response = self.client.post(reverse("item-manage-speaker", args=[self.item.pk]))
self.assertEqual(response.status_code, 400)
def test_remove_oneself(self):
2019-01-06 16:22:33 +01:00
Speaker.objects.add(get_user_model().objects.get(username="admin"), self.item)
response = self.client.delete(
2019-01-06 16:22:33 +01:00
reverse("item-manage-speaker", args=[self.item.pk])
)
self.assertEqual(response.status_code, 200)
self.assertFalse(Speaker.objects.all().exists())
def test_remove_self_not_on_list(self):
response = self.client.delete(
2019-01-06 16:22:33 +01:00
reverse("item-manage-speaker", args=[self.item.pk])
)
self.assertEqual(response.status_code, 400)
def test_add_someone_else(self):
response = self.client.post(
2019-01-06 16:22:33 +01:00
reverse("item-manage-speaker", args=[self.item.pk]), {"user": self.user.pk}
)
self.assertEqual(response.status_code, 200)
self.assertTrue(Speaker.objects.filter(item=self.item, user=self.user).exists())
def test_invalid_data_string_instead_of_integer(self):
response = self.client.post(
2019-01-06 16:22:33 +01:00
reverse("item-manage-speaker", args=[self.item.pk]),
{"user": "string_instead_of_integer"},
)
self.assertEqual(response.status_code, 400)
def test_invalid_data_user_does_not_exist(self):
# ID of a user that does not exist.
# Be careful: Here we do not test that the user does not exist.
inexistent_user_pk = self.user.pk + 1000
response = self.client.post(
2019-01-06 16:22:33 +01:00
reverse("item-manage-speaker", args=[self.item.pk]),
{"user": inexistent_user_pk},
)
self.assertEqual(response.status_code, 400)
def test_add_someone_else_twice(self):
Speaker.objects.add(self.user, self.item)
response = self.client.post(
2019-01-06 16:22:33 +01:00
reverse("item-manage-speaker", args=[self.item.pk]), {"user": self.user.pk}
)
self.assertEqual(response.status_code, 400)
def test_add_someone_else_non_admin(self):
2019-01-06 16:22:33 +01:00
admin = get_user_model().objects.get(username="admin")
group_admin = admin.groups.get(name="Admin")
group_delegates = type(group_admin).objects.get(name="Delegates")
admin.groups.add(group_delegates)
2018-02-23 13:00:47 +01:00
admin.groups.remove(group_admin)
2018-09-01 08:00:00 +02:00
inform_changed_data(admin)
response = self.client.post(
2019-01-06 16:22:33 +01:00
reverse("item-manage-speaker", args=[self.item.pk]), {"user": self.user.pk}
)
self.assertEqual(response.status_code, 403)
def test_remove_someone_else(self):
speaker = Speaker.objects.add(self.user, self.item)
response = self.client.delete(
2019-01-06 16:22:33 +01:00
reverse("item-manage-speaker", args=[self.item.pk]), {"speaker": speaker.pk}
)
self.assertEqual(response.status_code, 200)
2019-01-06 16:22:33 +01:00
self.assertFalse(
Speaker.objects.filter(item=self.item, user=self.user).exists()
)
def test_remove_someone_else_not_on_list(self):
response = self.client.delete(
2019-01-06 16:22:33 +01:00
reverse("item-manage-speaker", args=[self.item.pk]), {"speaker": "1"}
)
self.assertEqual(response.status_code, 200)
2015-05-27 15:42:32 +02:00
def test_remove_someone_else_invalid_data(self):
response = self.client.delete(
2019-01-06 16:22:33 +01:00
reverse("item-manage-speaker", args=[self.item.pk]), {"speaker": "invalid"}
)
self.assertEqual(response.status_code, 200)
2015-05-27 15:42:32 +02:00
def test_remove_someone_else_non_admin(self):
2019-01-06 16:22:33 +01:00
admin = get_user_model().objects.get(username="admin")
group_admin = admin.groups.get(name="Admin")
group_delegates = type(group_admin).objects.get(name="Delegates")
admin.groups.add(group_delegates)
2018-02-23 13:00:47 +01:00
admin.groups.remove(group_admin)
2018-09-01 08:00:00 +02:00
inform_changed_data(admin)
speaker = Speaker.objects.add(self.user, self.item)
response = self.client.delete(
2019-01-06 16:22:33 +01:00
reverse("item-manage-speaker", args=[self.item.pk]), {"speaker": speaker.pk}
)
self.assertEqual(response.status_code, 403)
2015-05-27 15:42:32 +02:00
2018-02-06 14:52:47 +01:00
def test_mark_speaker(self):
Speaker.objects.add(self.user, self.item)
response = self.client.patch(
2019-01-06 16:22:33 +01:00
reverse("item-manage-speaker", args=[self.item.pk]),
{"user": self.user.pk, "marked": True},
format="json",
2018-02-06 14:52:47 +01:00
)
self.assertEqual(response.status_code, 200)
self.assertTrue(Speaker.objects.get().marked)
def test_mark_speaker_non_admin(self):
2019-01-06 16:22:33 +01:00
admin = get_user_model().objects.get(username="admin")
group_admin = admin.groups.get(name="Admin")
group_delegates = type(group_admin).objects.get(name="Delegates")
2018-02-06 14:52:47 +01:00
admin.groups.add(group_delegates)
2018-02-23 13:00:47 +01:00
admin.groups.remove(group_admin)
2018-09-01 08:00:00 +02:00
inform_changed_data(admin)
2018-02-06 14:52:47 +01:00
Speaker.objects.add(self.user, self.item)
response = self.client.patch(
2019-01-06 16:22:33 +01:00
reverse("item-manage-speaker", args=[self.item.pk]), {"user": self.user.pk}
)
2018-02-06 14:52:47 +01:00
self.assertEqual(response.status_code, 403)
2015-05-27 15:42:32 +02:00
class Speak(TestCase):
"""
Tests view to begin or end speech.
2015-05-27 15:42:32 +02:00
"""
2019-01-06 16:22:33 +01:00
2015-05-27 15:42:32 +02:00
def setUp(self):
self.client = APIClient()
2019-01-06 16:22:33 +01:00
self.client.login(username="admin", password="admin")
self.item = Topic.objects.create(
title="test_title_KooDueco3zaiGhiraiho"
).agenda_item
2015-05-27 15:42:32 +02:00
self.user = get_user_model().objects.create_user(
2019-01-06 16:22:33 +01:00
username="test_user_Aigh4vohb3seecha4aa4",
password="test_password_eneupeeVo5deilixoo8j",
)
2015-05-27 15:42:32 +02:00
def test_begin_speech(self):
2015-05-27 15:42:32 +02:00
Speaker.objects.add(self.user, self.item)
2019-01-06 16:22:33 +01:00
speaker = Speaker.objects.add(
get_user_model().objects.get(username="admin"), self.item
)
2015-05-27 15:42:32 +02:00
self.assertTrue(Speaker.objects.get(pk=speaker.pk).begin_time is None)
response = self.client.put(
2019-01-06 16:22:33 +01:00
reverse("item-speak", args=[self.item.pk]), {"speaker": speaker.pk}
)
2015-05-27 15:42:32 +02:00
self.assertEqual(response.status_code, 200)
self.assertFalse(Speaker.objects.get(pk=speaker.pk).begin_time is None)
def test_begin_speech_next_speaker(self):
2015-05-27 15:42:32 +02:00
speaker = Speaker.objects.add(self.user, self.item)
2019-01-06 16:22:33 +01:00
Speaker.objects.add(get_user_model().objects.get(username="admin"), self.item)
2019-01-06 16:22:33 +01:00
response = self.client.put(reverse("item-speak", args=[self.item.pk]))
2015-05-27 15:42:32 +02:00
self.assertEqual(response.status_code, 200)
self.assertFalse(Speaker.objects.get(pk=speaker.pk).begin_time is None)
def test_begin_speech_invalid_speaker_id(self):
2015-05-27 15:42:32 +02:00
response = self.client.put(
2019-01-06 16:22:33 +01:00
reverse("item-speak", args=[self.item.pk]), {"speaker": "1"}
)
2015-05-27 15:42:32 +02:00
self.assertEqual(response.status_code, 400)
def test_begin_speech_invalid_data(self):
2015-05-27 15:42:32 +02:00
response = self.client.put(
2019-01-06 16:22:33 +01:00
reverse("item-speak", args=[self.item.pk]), {"speaker": "invalid"}
)
2015-05-27 15:42:32 +02:00
self.assertEqual(response.status_code, 400)
def test_end_speech(self):
2019-01-06 16:22:33 +01:00
speaker = Speaker.objects.add(
get_user_model().objects.get(username="admin"), self.item
)
speaker.begin_speech()
2015-05-27 15:42:32 +02:00
self.assertFalse(Speaker.objects.get(pk=speaker.pk).begin_time is None)
self.assertTrue(Speaker.objects.get(pk=speaker.pk).end_time is None)
2019-01-06 16:22:33 +01:00
response = self.client.delete(reverse("item-speak", args=[self.item.pk]))
2015-05-27 15:42:32 +02:00
self.assertEqual(response.status_code, 200)
self.assertFalse(Speaker.objects.get(pk=speaker.pk).end_time is None)
def test_end_speech_no_current_speaker(self):
2019-01-06 16:22:33 +01:00
response = self.client.delete(reverse("item-speak", args=[self.item.pk]))
2015-05-27 15:42:32 +02:00
self.assertEqual(response.status_code, 400)
def test_begin_speech_with_countdown(self):
2019-01-06 16:22:33 +01:00
config["agenda_couple_countdown_and_speakers"] = True
Speaker.objects.add(self.user, self.item)
2019-01-06 16:22:33 +01:00
speaker = Speaker.objects.add(
get_user_model().objects.get(username="admin"), self.item
)
self.client.put(
2019-01-06 16:22:33 +01:00
reverse("item-speak", args=[self.item.pk]), {"speaker": speaker.pk}
)
# Countdown should be created with pk=1 and running
self.assertEqual(Countdown.objects.all().count(), 1)
countdown = Countdown.objects.get(pk=1)
self.assertTrue(countdown.running)
def test_end_speech_with_countdown(self):
2019-01-06 16:22:33 +01:00
config["agenda_couple_countdown_and_speakers"] = True
speaker = Speaker.objects.add(
get_user_model().objects.get(username="admin"), self.item
)
speaker.begin_speech()
2019-01-06 16:22:33 +01:00
self.client.delete(reverse("item-speak", args=[self.item.pk]))
# Countdown should be created with pk=1 and stopped
self.assertEqual(Countdown.objects.all().count(), 1)
countdown = Countdown.objects.get(pk=1)
self.assertFalse(countdown.running)
class Numbering(TestCase):
"""
Tests view to number the agenda
"""
2019-01-06 16:22:33 +01:00
def setUp(self):
self.client = APIClient()
2019-01-06 16:22:33 +01:00
self.client.login(username="admin", password="admin")
self.item_1 = Topic.objects.create(
title="test_title_thuha8eef7ohXar3eech"
).agenda_item
self.item_1.type = Item.AGENDA_ITEM
self.item_1.weight = 1
self.item_1.save()
2019-01-06 16:22:33 +01:00
self.item_2 = Topic.objects.create(
title="test_title_eisah7thuxa1eingaeLo"
).agenda_item
self.item_2.type = Item.AGENDA_ITEM
self.item_2.weight = 2
self.item_2.save()
2019-01-06 16:22:33 +01:00
self.item_2_1 = Topic.objects.create(
title="test_title_Qui0audoaz5gie1phish"
).agenda_item
self.item_2_1.type = Item.AGENDA_ITEM
self.item_2_1.parent = self.item_2
self.item_2_1.save()
2019-01-06 16:22:33 +01:00
self.item_3 = Topic.objects.create(
title="test_title_ah7tphisheineisgaeLo"
).agenda_item
self.item_3.type = Item.AGENDA_ITEM
self.item_3.weight = 3
self.item_3.save()
def test_numbering(self):
2019-01-06 16:22:33 +01:00
response = self.client.post(reverse("item-numbering"))
self.assertEqual(response.status_code, 200)
2019-01-06 16:22:33 +01:00
self.assertEqual(Item.objects.get(pk=self.item_1.pk).item_number, "1")
self.assertEqual(Item.objects.get(pk=self.item_2.pk).item_number, "2")
self.assertEqual(Item.objects.get(pk=self.item_2_1.pk).item_number, "2.1")
self.assertEqual(Item.objects.get(pk=self.item_3.pk).item_number, "3")
2018-04-11 12:35:42 +02:00
def test_deactivated_numbering(self):
2019-01-06 16:22:33 +01:00
config["agenda_enable_numbering"] = False
2018-04-11 12:35:42 +02:00
2019-01-06 16:22:33 +01:00
response = self.client.post(reverse("item-numbering"))
2018-04-11 12:35:42 +02:00
self.assertEqual(response.status_code, 400)
def test_roman_numbering(self):
2019-01-06 16:22:33 +01:00
config["agenda_numeral_system"] = "roman"
2019-01-06 16:22:33 +01:00
response = self.client.post(reverse("item-numbering"))
self.assertEqual(response.status_code, 200)
2019-01-06 16:22:33 +01:00
self.assertEqual(Item.objects.get(pk=self.item_1.pk).item_number, "I")
self.assertEqual(Item.objects.get(pk=self.item_2.pk).item_number, "II")
self.assertEqual(Item.objects.get(pk=self.item_2_1.pk).item_number, "II.1")
self.assertEqual(Item.objects.get(pk=self.item_3.pk).item_number, "III")
def test_with_internal_item(self):
self.item_2.type = Item.INTERNAL_ITEM
self.item_2.save()
2019-01-06 16:22:33 +01:00
response = self.client.post(reverse("item-numbering"))
self.assertEqual(response.status_code, 200)
2019-01-06 16:22:33 +01:00
self.assertEqual(Item.objects.get(pk=self.item_1.pk).item_number, "1")
self.assertEqual(Item.objects.get(pk=self.item_2.pk).item_number, "")
self.assertEqual(Item.objects.get(pk=self.item_2_1.pk).item_number, "")
self.assertEqual(Item.objects.get(pk=self.item_3.pk).item_number, "2")
2016-01-25 22:10:00 +01:00
def test_reset_numbering_with_internal_item(self):
2019-01-06 16:22:33 +01:00
self.item_2.item_number = "test_number_Cieghae6ied5ool4hiem"
self.item_2.type = Item.INTERNAL_ITEM
2016-01-25 22:10:00 +01:00
self.item_2.save()
2019-01-06 16:22:33 +01:00
self.item_2_1.item_number = "test_number_roQueTohg7fe1Is7aemu"
2016-01-25 22:10:00 +01:00
self.item_2_1.save()
2019-01-06 16:22:33 +01:00
response = self.client.post(reverse("item-numbering"))
2016-01-25 22:10:00 +01:00
self.assertEqual(response.status_code, 200)
2019-01-06 16:22:33 +01:00
self.assertEqual(Item.objects.get(pk=self.item_1.pk).item_number, "1")
self.assertEqual(Item.objects.get(pk=self.item_2.pk).item_number, "")
self.assertEqual(Item.objects.get(pk=self.item_2_1.pk).item_number, "")
self.assertEqual(Item.objects.get(pk=self.item_3.pk).item_number, "2")