From 058d87eb77a73de9b98e55c0c06b0a16dbd9eea9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tobias=20Ho=CC=88=C3=9Fl?= <tobias@hoessl.eu>
Date: Sun, 16 Dec 2018 14:41:32 +0100
Subject: [PATCH] Bugfix: change detection for change recommendations

---
 .../motion-detail-diff.component.html                |  4 ++--
 .../motion-detail-diff.component.ts                  | 12 +++++++-----
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/client/src/app/site/motions/components/motion-detail-diff/motion-detail-diff.component.html b/client/src/app/site/motions/components/motion-detail-diff/motion-detail-diff.component.html
index 16a8245c2..f409942c8 100644
--- a/client/src/app/site/motions/components/motion-detail-diff/motion-detail-diff.component.html
+++ b/client/src/app/site/motions/components/motion-detail-diff/motion-detail-diff.component.html
@@ -111,7 +111,7 @@
         <button
             type="button"
             mat-menu-item
-            [disabled]="hasCollissions(change)"
+            [disabled]="hasCollissions(change, changes)"
             (click)="setAcceptanceValue(change, 'accepted')"
         >
             <mat-icon>thumb_up</mat-icon>
@@ -121,7 +121,7 @@
         <button
             type="button"
             mat-menu-item
-            [disabled]="hasCollissions(change)"
+            [disabled]="hasCollissions(change, changes)"
             (click)="setAcceptanceValue(change, 'rejected')"
         >
             <mat-icon>thumb_down</mat-icon>
diff --git a/client/src/app/site/motions/components/motion-detail-diff/motion-detail-diff.component.ts b/client/src/app/site/motions/components/motion-detail-diff/motion-detail-diff.component.ts
index 931dee776..5d995fb58 100644
--- a/client/src/app/site/motions/components/motion-detail-diff/motion-detail-diff.component.ts
+++ b/client/src/app/site/motions/components/motion-detail-diff/motion-detail-diff.component.ts
@@ -101,11 +101,13 @@ export class MotionDetailDiffComponent extends BaseViewComponent implements Afte
         return (
             changes.filter((otherChange: ViewUnifiedChange) => {
                 return (
-                    (otherChange.getChangeId() === change.getChangeId() &&
-                        (otherChange.getLineFrom() >= change.getLineFrom() &&
-                            otherChange.getLineFrom() < change.getLineTo())) ||
-                    (otherChange.getLineTo() > change.getLineFrom() && otherChange.getLineTo() <= change.getLineTo()) ||
-                    (otherChange.getLineFrom() < change.getLineFrom() && otherChange.getLineTo() > change.getLineTo())
+                    otherChange.getChangeId() !== change.getChangeId() &&
+                    ((otherChange.getLineFrom() >= change.getLineFrom() &&
+                        otherChange.getLineFrom() < change.getLineTo()) ||
+                        (otherChange.getLineTo() > change.getLineFrom() &&
+                            otherChange.getLineTo() <= change.getLineTo()) ||
+                        (otherChange.getLineFrom() < change.getLineFrom() &&
+                            otherChange.getLineTo() > change.getLineTo()))
                 );
             }).length > 0
         );