From 07d3ea4c25d2a5af5c182bb9143152de3cfd37a8 Mon Sep 17 00:00:00 2001
From: Sean Engelhardt <sean.f.t.engelhardt@gmail.com>
Date: Fri, 8 Mar 2019 16:45:45 +0100
Subject: [PATCH] Fix amendment creation

Categories and blocks not appear after (paragraph based) amendment
creation.
Reason for amendments is now required if the config was set
accordingly
---
 .../amendment-create-wizard.component.html    | 53 ++++++++++++++++---
 .../amendment-create-wizard.component.ts      | 26 ++++-----
 .../motion-detail.component.html              |  2 +-
 .../motion-detail/motion-detail.component.ts  |  7 +++
 4 files changed, 66 insertions(+), 22 deletions(-)

diff --git a/client/src/app/site/motions/modules/motion-detail/components/amendment-create-wizard/amendment-create-wizard.component.html b/client/src/app/site/motions/modules/motion-detail/components/amendment-create-wizard/amendment-create-wizard.component.html
index 09b6948b4..d38ff9832 100644
--- a/client/src/app/site/motions/modules/motion-detail/components/amendment-create-wizard/amendment-create-wizard.component.html
+++ b/client/src/app/site/motions/modules/motion-detail/components/amendment-create-wizard/amendment-create-wizard.component.html
@@ -37,13 +37,54 @@
         <mat-step>
             <ng-template matStepLabel>{{ 'Change paragraph' | translate }}</ng-template>
 
-            <h5 translate>Amendment text</h5>
-            <!-- The HTML Editor -->
-            <editor formControlName="text" [init]="tinyMceSettings"></editor>
+            <!-- Text -->
+            <h3
+                [ngClass]="
+                    contentForm.get('text').invalid &&
+                    (contentForm.get('text').dirty || contentForm.get('text').touched)
+                        ? 'red-warning-text'
+                        : ''
+                "
+            >
+                <span translate>Amendment text</span>&nbsp;<span>*</span>
+            </h3>
+            <editor formControlName="text" [init]="tinyMceSettings" required></editor>
+            <div
+                *ngIf="
+                    contentForm.get('text').invalid &&
+                    (contentForm.get('text').dirty || contentForm.get('text').touched)
+                "
+                class="red-warning-text"
+                translate
+            >
+                This field is required.
+            </div>
 
-            <h5 translate>Reason</h5>
-            <!-- The HTML Editor -->
-            <editor formControlName="reason" [init]="tinyMceSettings"></editor>
+            <!-- Reason -->
+            <h3
+                [ngClass]="
+                    reasonRequired &&
+                    contentForm.get('reason').invalid &&
+                    (contentForm.get('reason').dirty || contentForm.get('reason').touched)
+                        ? 'red-warning-text'
+                        : ''
+                "
+            >
+                <span translate>Reason</span>&nbsp;<span *ngIf="reasonRequired">*</span>
+            </h3>
+
+            <editor formControlName="reason" [init]="tinyMceSettings" required></editor>
+            <div
+                *ngIf="
+                    reasonRequired &&
+                    contentForm.get('reason').invalid &&
+                    (contentForm.get('reason').dirty || contentForm.get('reason').touched)
+                "
+                class="red-warning-text"
+                translate
+            >
+                This field is required.
+            </div>
         </mat-step>
     </mat-horizontal-stepper>
 </form>
diff --git a/client/src/app/site/motions/modules/motion-detail/components/amendment-create-wizard/amendment-create-wizard.component.ts b/client/src/app/site/motions/modules/motion-detail/components/amendment-create-wizard/amendment-create-wizard.component.ts
index a6e03a1bb..c981921e5 100644
--- a/client/src/app/site/motions/modules/motion-detail/components/amendment-create-wizard/amendment-create-wizard.component.ts
+++ b/client/src/app/site/motions/modules/motion-detail/components/amendment-create-wizard/amendment-create-wizard.component.ts
@@ -57,16 +57,16 @@ export class AmendmentCreateWizardComponent extends BaseViewComponent {
      */
     public contentForm: FormGroup;
 
-    /**
-     * Motions meta-info
-     */
-    public metaInfoForm: FormGroup;
-
     /**
      * Indicates the maximum line length as defined in the configuration.
      */
     public lineLength: number;
 
+    /**
+     * Determine, from the config service, if a reason is required
+     */
+    public reasonRequired: boolean;
+
     /**
      * Constructs this component.
      *
@@ -100,6 +100,10 @@ export class AmendmentCreateWizardComponent extends BaseViewComponent {
             this.lineLength = lineLength;
             this.getMotionByUrl();
         });
+
+        this.configService.get<boolean>('motions_reason_required').subscribe(required => {
+            this.reasonRequired = required;
+        });
     }
 
     /**
@@ -133,15 +137,6 @@ export class AmendmentCreateWizardComponent extends BaseViewComponent {
             text: ['', Validators.required],
             reason: ['', Validators.required]
         });
-        this.metaInfoForm = this.formBuilder.group({
-            identifier: [''],
-            category_id: [''],
-            state_id: [''],
-            recommendation_id: [''],
-            submitters_id: [],
-            supporters_id: [[]],
-            origin: ['']
-        });
     }
 
     /**
@@ -172,10 +167,11 @@ export class AmendmentCreateWizardComponent extends BaseViewComponent {
             }
         );
         const newMotionValues = {
-            ...this.metaInfoForm.value,
             ...this.contentForm.value,
             title: this.translate.instant('Amendment to') + ' ' + this.motion.identifier,
             parent_id: this.motion.id,
+            category_id: this.motion.category_id,
+            motion_block_id: this.motion.motion_block_id,
             amendment_paragraphs: amendedParagraphs
         };
 
diff --git a/client/src/app/site/motions/modules/motion-detail/components/motion-detail/motion-detail.component.html b/client/src/app/site/motions/modules/motion-detail/components/motion-detail/motion-detail.component.html
index 64e60ac78..e20222143 100644
--- a/client/src/app/site/motions/modules/motion-detail/components/motion-detail/motion-detail.component.html
+++ b/client/src/app/site/motions/modules/motion-detail/components/motion-detail/motion-detail.component.html
@@ -1,7 +1,7 @@
 <os-head-bar
     [mainButton]="perms.isAllowed('update', motion)"
     mainButtonIcon="edit"
-    prevUrl="../.."
+    [prevUrl]="backTarget"
     [nav]="false"
     [editMode]="editMotion"
     (mainEvent)="setEditMode(!editMotion)"
diff --git a/client/src/app/site/motions/modules/motion-detail/components/motion-detail/motion-detail.component.ts b/client/src/app/site/motions/modules/motion-detail/components/motion-detail/motion-detail.component.ts
index 94034f4ba..e08970135 100644
--- a/client/src/app/site/motions/modules/motion-detail/components/motion-detail/motion-detail.component.ts
+++ b/client/src/app/site/motions/modules/motion-detail/components/motion-detail/motion-detail.component.ts
@@ -337,6 +337,13 @@ export class MotionDetailComponent extends BaseViewComponent implements OnInit,
      */
     private editNotificationSubscription: Subscription;
 
+    /**
+     * Determine what to "return" to.
+     * Handles the target for clicking the back button
+     * Several angular peculiarities prevent dynamic changing from working right now
+     */
+    public backTarget = '../..';
+
     /**
      * Constructs the detail view.
      *