Handel null=True in PersonField

openslides/utils/person/api.py

@@ -10,7 +10,7 @@
     :license: GNU GPL, see LICENSE for more details.
 """
 
-from openslides.utils.person.signals import receive_persons
+from .signals import receive_persons
 
 
 class Person(object):

openslides/utils/person/models.py

@@ -11,16 +11,16 @@
 """
 from django.db import models
 
-from openslides.utils.person.forms import PersonFormField
+from .forms import PersonFormField
-from openslides.utils.person.api import get_person, generate_person_id
+from .api import get_person, generate_person_id, Person
 
 
 class PersonField(models.fields.Field):
     __metaclass__ = models.SubfieldBase
 
     def __init__(self, *args, **kwargs):
-        super(PersonField, self).__init__(max_length=255, *args, **kwargs)
+        kwargs['max_length'] = 255
-        # TODO: Validate the uid
+        super(PersonField, self).__init__(*args, **kwargs)
 
     def get_internal_type(self):
         return "CharField"
@@ -29,22 +29,22 @@ class PersonField(models.fields.Field):
         """
         Convert string value to a User Object.
         """
-        if hasattr(value, 'person_id'):
+        if isinstance(value, Person):
-            person = value
+            return value
+        elif value is None:
+            return None
         else:
-            person = get_person(value)
+            return get_person(value)
-
-        person.prepare_database_save = (
-            lambda unused: PersonField().get_prep_value(person))
-        return person
 
     def get_prep_value(self, value):
+        """
+        Convert a person object to a string, to store it in the database.
+        """
+        if value is None:
+            return None
+        else:
             return value.person_id
 
-    def value_to_string(self, obj):
-        value = self._get_val_from_obj(obj)
-        return self.get_prep_value(value)
-
     def formfield(self, **kwargs):
         defaults = {'form_class': PersonFormField}
         defaults.update(kwargs)