ag-admin/OpenSlides
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Limit pushing of filter updates in filter service

Browse Source 
Limits the pushing updateFilteredData in the baseFilterList service
to only listen for actual changes of the list input data
This should decrease client stress on autoupdates
This commit is contained in:
Sean 2021-06-04 14:26:18 +02:00
parent 136e0a0569
commit 15fb19ad2f
1 changed files with 18 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
client/src/app/core/ui-services/base-filter-list.service.ts
View File

@ -1,4 +1,5 @@
import { BehaviorSubject, Observable, Subscription } from 'rxjs';
import { distinctUntilChanged } from 'rxjs/operators';
import { BaseModel } from 'app/shared/models/base/base-model';
import { BaseRepository } from '../repositories/base-repository';
@ -182,10 +183,23 @@ export abstract class BaseFilterListService<V extends BaseViewModel> {
this.inputDataSubscription.unsubscribe();
this.inputDataSubscription = null;
}
this.inputDataSubscription = inputData.subscribe(data => {
this.inputData = data;
this.updateFilteredData();
});
this.inputDataSubscription = inputData
/**
* Every autoupdate pushes data here.
* Not entirely sure why this happens.
* However, we are only concerned about changes to our
* current moddels, so compare the changes should
* limit the updating of filters
*/
.pipe(
distinctUntilChanged((curr, prev) => {
return curr.length === prev.length && curr.every((v, i) => v === prev[i]);
})
)
.subscribe(data => {
this.inputData = data;
this.updateFilteredData();
});
}
/**