From 81c50f5b2f4439b064353333bdeca7dde33398b0 Mon Sep 17 00:00:00 2001
From: Maximilian Krambach <maximilian.krambach@intevation.de>
Date: Fri, 12 Apr 2019 13:23:22 +0200
Subject: [PATCH] bulk set/unset favorite status

---
 .../core/ui-services/personal-note.service.ts | 36 ++++++++++++++++
 .../personal-note.component.html              |  2 +-
 .../motion-list/motion-list.component.html    |  4 ++
 .../services/motion-multiselect.service.ts    | 42 ++++++++++++++-----
 4 files changed, 73 insertions(+), 11 deletions(-)

diff --git a/client/src/app/core/ui-services/personal-note.service.ts b/client/src/app/core/ui-services/personal-note.service.ts
index b181259ea..4c915c20b 100644
--- a/client/src/app/core/ui-services/personal-note.service.ts
+++ b/client/src/app/core/ui-services/personal-note.service.ts
@@ -60,6 +60,42 @@ export class PersonalNoteService {
         }
 
         pnObject.notes[model.collectionString][model.id] = content;
+        this.savePersonalNoteObject(pnObject);
+    }
+
+    /**
+     * Sets the 'favorite' status for several models of a type in bulk
+     *
+     * @param models The model the content belongs to
+     * @param star The new 'favorite' status
+     */
+    public async bulkSetStar(models: (BaseModel | BaseViewModel)[], star: boolean): Promise<void> {
+        if (!models.length) {
+            return;
+        }
+        const pnObject: Partial<PersonalNoteObject> = this.personalNoteObject || {};
+        if (!pnObject.notes) {
+            pnObject.notes = {};
+        }
+        for (const model of models) {
+            if (!pnObject.notes[model.collectionString]) {
+                pnObject.notes[model.collectionString] = {};
+            }
+            if (pnObject.notes[model.collectionString][model.id]) {
+                pnObject.notes[model.collectionString][model.id].star = star;
+            } else {
+                pnObject.notes[model.collectionString][model.id] = { star: star, note: '' };
+            }
+        }
+        await this.savePersonalNoteObject(pnObject);
+    }
+
+    /**
+     * Sends an updated personal note to the server
+     *
+     * @param pnObject a partial (if new) or complete personal note object
+     */
+    private async savePersonalNoteObject(pnObject: Partial<PersonalNoteObject>): Promise<void> {
         if (!pnObject.id) {
             await this.http.post('rest/users/personal-note/', pnObject);
         } else {
diff --git a/client/src/app/site/motions/modules/motion-detail/components/personal-note/personal-note.component.html b/client/src/app/site/motions/modules/motion-detail/components/personal-note/personal-note.component.html
index 9892ffd9c..3778b4906 100644
--- a/client/src/app/site/motions/modules/motion-detail/components/personal-note/personal-note.component.html
+++ b/client/src/app/site/motions/modules/motion-detail/components/personal-note/personal-note.component.html
@@ -6,7 +6,7 @@
     <ng-container class="meta-text-block-content">
         <ng-container *ngIf="!isEditMode">
             <div *ngIf="motion && motion.personalNote" [innerHTML]="sanitizeText(motion.personalNote.note)"></div>
-            <div class="no-content" *ngIf="!motion || !motion.personalNote" translate>
+            <div class="no-content" *ngIf="!motion || !motion.personalNote || !motion.personalNote.note" translate>
                 No personal note
             </div>
         </ng-container>
diff --git a/client/src/app/site/motions/modules/motion-list/components/motion-list/motion-list.component.html b/client/src/app/site/motions/modules/motion-list/components/motion-list/motion-list.component.html
index cb3416f37..c0ec1d13d 100644
--- a/client/src/app/site/motions/modules/motion-list/components/motion-list/motion-list.component.html
+++ b/client/src/app/site/motions/modules/motion-list/components/motion-list/motion-list.component.html
@@ -221,6 +221,10 @@
         </button>
         <div *ngIf="perms.isAllowed('change_metadata')">
             <mat-divider></mat-divider>
+            <button mat-menu-item (click)="multiselectWrapper(multiselectService.bulkToggleFavorite(selectedRows))">
+                <mat-icon>star</mat-icon>
+                <span translate>Set/unset Favorite</span>
+            </button>
             <button mat-menu-item (click)="multiselectWrapper(multiselectService.setStateOfMultiple(selectedRows))">
                 <mat-icon>label</mat-icon>
                 <span translate>Set status</span>
diff --git a/client/src/app/site/motions/services/motion-multiselect.service.ts b/client/src/app/site/motions/services/motion-multiselect.service.ts
index 0d5c59233..cf39f73b3 100644
--- a/client/src/app/site/motions/services/motion-multiselect.service.ts
+++ b/client/src/app/site/motions/services/motion-multiselect.service.ts
@@ -2,20 +2,22 @@ import { Injectable } from '@angular/core';
 
 import { TranslateService } from '@ngx-translate/core';
 
-import { ViewMotion } from '../models/view-motion';
-import { ChoiceService } from 'app/core/ui-services/choice.service';
-import { PromptService } from 'app/core/ui-services/prompt.service';
-import { MotionRepositoryService } from 'app/core/repositories/motions/motion-repository.service';
-import { UserRepositoryService } from 'app/core/repositories/users/user-repository.service';
-import { WorkflowRepositoryService } from 'app/core/repositories/motions/workflow-repository.service';
 import { CategoryRepositoryService } from 'app/core/repositories/motions/category-repository.service';
-import { TagRepositoryService } from 'app/core/repositories/tags/tag-repository.service';
-import { HttpService } from 'app/core/core-services/http.service';
-import { ItemRepositoryService } from 'app/core/repositories/agenda/item-repository.service';
+import { ChoiceDialogOptions } from 'app/shared/components/choice-dialog/choice-dialog.component';
+import { ChoiceService } from 'app/core/ui-services/choice.service';
 import { Displayable } from 'app/site/base/displayable';
+import { HttpService } from 'app/core/core-services/http.service';
 import { Identifiable } from 'app/shared/models/base/identifiable';
+import { ItemRepositoryService } from 'app/core/repositories/agenda/item-repository.service';
 import { MotionBlockRepositoryService } from 'app/core/repositories/motions/motion-block-repository.service';
+import { MotionRepositoryService } from 'app/core/repositories/motions/motion-repository.service';
+import { PersonalNoteService } from 'app/core/ui-services/personal-note.service';
+import { PromptService } from 'app/core/ui-services/prompt.service';
+import { TagRepositoryService } from 'app/core/repositories/tags/tag-repository.service';
 import { TreeService } from 'app/core/ui-services/tree.service';
+import { UserRepositoryService } from 'app/core/repositories/users/user-repository.service';
+import { ViewMotion } from '../models/view-motion';
+import { WorkflowRepositoryService } from 'app/core/repositories/motions/workflow-repository.service';
 
 /**
  * Contains all multiselect actions for the motion list view.
@@ -39,6 +41,7 @@ export class MotionMultiselectService {
      * @param motionBlockRepo
      * @param httpService
      * @param treeService
+     * @param personalNoteService
      */
     public constructor(
         private repo: MotionRepositoryService,
@@ -52,7 +55,8 @@ export class MotionMultiselectService {
         private agendaRepo: ItemRepositoryService,
         private motionBlockRepo: MotionBlockRepositoryService,
         private httpService: HttpService,
-        private treeService: TreeService
+        private treeService: TreeService,
+        private personalNoteService: PersonalNoteService
     ) {}
 
     /**
@@ -299,4 +303,22 @@ export class MotionMultiselectService {
             }
         }
     }
+
+    /**
+     * Bulk sets/unsets the favorite status (after a confirmation dialog)
+     *
+     * @param motions The motions to set/unset the favorite status for
+     */
+    public async bulkSetFavorite(motions: ViewMotion[]): Promise<void> {
+        const title = this.translate.instant('This will set the favorite status for all selected motions:');
+        const choices: ChoiceDialogOptions = [
+            { id: 1, label: this.translate.instant('Set as favorite') },
+            { id: 2, label: this.translate.instant('Set as not favorite') }
+        ];
+        const selectedChoice = await this.choiceService.open(title, choices);
+        if (selectedChoice && motions.length) {
+            const star = (selectedChoice.items as number) === choices[0].id;
+            await this.personalNoteService.bulkSetStar(motions, star);
+        }
+    }
 }