From d1b52a9302c243cf46c88cba26da797f3413835b Mon Sep 17 00:00:00 2001
From: FinnStutzenstein <finn.stutzenstein@hotmail.de>
Date: Mon, 27 Aug 2018 11:23:58 +0200
Subject: [PATCH] Hide Sort button in agenda (closes #3812)

---
 .../agenda/static/templates/agenda/item-list.html      | 10 ++++++----
 openslides/agenda/views.py                             |  4 ++--
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/openslides/agenda/static/templates/agenda/item-list.html b/openslides/agenda/static/templates/agenda/item-list.html
index 49ee40b02..77b5e3506 100644
--- a/openslides/agenda/static/templates/agenda/item-list.html
+++ b/openslides/agenda/static/templates/agenda/item-list.html
@@ -73,10 +73,12 @@
         <translate>Select ...</translate>
       </button>
       <!-- sort button -->
-      <a ui-sref="agenda.item.sort" os-perms="agenda.can_manage" class="btn btn-default btn-sm">
-        <i class="fa fa-sitemap fa-lg"></i>
-        <translate>Sort ...</translate>
-      </a>
+      <span os-perms="agenda.can_see_internal_items">
+        <a ui-sref="agenda.item.sort" os-perms="agenda.can_manage" class="btn btn-default btn-sm">
+          <i class="fa fa-sitemap fa-lg"></i>
+          <translate>Sort ...</translate>
+        </a>
+      </span>
       <!-- auto numbering button -->
       <span ng-if="config('agenda_enable_numbering')">
         <button os-perms="agenda.can_manage" class="btn btn-default btn-sm"
diff --git a/openslides/agenda/views.py b/openslides/agenda/views.py
index b699b1b22..f324c57d0 100644
--- a/openslides/agenda/views.py
+++ b/openslides/agenda/views.py
@@ -44,14 +44,14 @@ class ItemViewSet(ListModelMixin, RetrieveModelMixin, UpdateModelMixin, GenericV
             result = has_perm(self.request.user, 'agenda.can_see')
             # For manage_speaker and tree requests the rest of the check is
             # done in the specific method. See below.
-        elif self.action in ('partial_update', 'update'):
+        elif self.action in ('partial_update', 'update', 'sort'):
             result = (has_perm(self.request.user, 'agenda.can_see') and
                       has_perm(self.request.user, 'agenda.can_see_internal_items') and
                       has_perm(self.request.user, 'agenda.can_manage'))
         elif self.action in ('speak', 'sort_speakers'):
             result = (has_perm(self.request.user, 'agenda.can_see') and
                       has_perm(self.request.user, 'agenda.can_manage_list_of_speakers'))
-        elif self.action in ('numbering', 'sort'):
+        elif self.action in ('numbering'):
             result = (has_perm(self.request.user, 'agenda.can_see') and
                       has_perm(self.request.user, 'agenda.can_manage'))
         else: