ag-admin/OpenSlides
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Prevent double "TOP" in agenda pdf

Browse Source 
Also: changes the definition of "getTitle" and "getAgendaTitle" to be more
consistent and easier to guess. getTitle will simply return the title, while getAgendaTitle
returns the title with the agenda-prefix
This commit is contained in:
Sean 2020-06-12 13:23:44 +02:00
parent f590994875
commit 1f876ec6dd
4 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
client/src/app/core/repositories/topics/topic-repository.service.ts
View File

@ -53,16 +53,19 @@ export class TopicRepositoryService extends BaseIsAgendaItemAndListOfSpeakersCon
}
public getTitle = (titleInformation: TopicTitleInformation) => {
return titleInformation.title;
};
public getListTitle = (titleInformation: TopicTitleInformation) => {
if (titleInformation.agenda_item_number && titleInformation.agenda_item_number()) {
return `${titleInformation.agenda_item_number()} · ${titleInformation.title}`;
} else {
return titleInformation.title;
return this.getTitle(titleInformation);
}
};
public getAgendaListTitle = (titleInformation: TopicTitleInformation) => {
// Do not append ' (Topic)' to the title.
return { title: this.getTitle(titleInformation) };
return { title: this.getListTitle(titleInformation) };
};
public getAgendaSlideTitle = (titleInformation: TopicTitleInformation) => {

2
client/src/app/site/agenda/services/agenda-pdf.service.ts
View File

@ -87,7 +87,7 @@ export class AgendaPdfService {
text: nodeItem.item.item_number
},
{
text: nodeItem.item.contentObject.getListTitle()
text: nodeItem.item.contentObject.getTitle()
}
]
};

2
client/src/app/site/base/base-view-model-with-agenda-item.ts
View File

@ -68,7 +68,7 @@ export abstract class BaseViewModelWithAgendaItem<
*/
public getProjectorTitle(): ProjectorTitle {
const subtitle = this.item ? this.item.comment : null;
return { title: this.getTitle(), subtitle };
return { title: this.getListTitle(), subtitle };
}
/**

2
client/src/app/site/topics/components/topic-detail/topic-detail.component.html
View File

@ -27,7 +27,7 @@
<mat-card *ngIf="topic || editTopic" [ngClass]="editTopic ? 'os-form-card' : 'os-card'">
<div *ngIf="!editTopic">
<h1>{{ topic.getTitle() }}</h1>
<h1>{{ topic.getListTitle() }}</h1>
</div>
<div>
<span *ngIf="!editTopic">