From aa46922c8b9feef1299191e276cf5ef643b72c12 Mon Sep 17 00:00:00 2001
From: Joshua Sangmeister <joshua.sangmeister@gmail.com>
Date: Thu, 12 Mar 2020 11:49:34 +0100
Subject: [PATCH] added an indicator if all motions of a block are finished

---
 .../site/motions/models/view-motion-block.ts  |  7 ++++++
 .../motion-block-detail.component.html        | 22 +++++++++++++++----
 .../motion-block-detail.component.ts          |  1 +
 .../motion-block-list.component.html          | 22 ++++++++++++++-----
 4 files changed, 43 insertions(+), 9 deletions(-)

diff --git a/client/src/app/site/motions/models/view-motion-block.ts b/client/src/app/site/motions/models/view-motion-block.ts
index 0e0ba32ca..b2182694d 100644
--- a/client/src/app/site/motions/models/view-motion-block.ts
+++ b/client/src/app/site/motions/models/view-motion-block.ts
@@ -23,6 +23,13 @@ export class ViewMotionBlock extends BaseViewModelWithAgendaItemAndListOfSpeaker
         return this._model;
     }
 
+    /**
+     * A block is finished when all its motions are in a final state
+     */
+    public get isFinished(): boolean {
+        return this.motions && this.motions.length && this.motions.every(motion => motion.isInFinalState());
+    }
+
     /**
      * Formats the category for search
      *
diff --git a/client/src/app/site/motions/modules/motion-block/components/motion-block-detail/motion-block-detail.component.html b/client/src/app/site/motions/modules/motion-block/components/motion-block-detail/motion-block-detail.component.html
index 80c70702a..651e66f80 100644
--- a/client/src/app/site/motions/modules/motion-block/components/motion-block-detail/motion-block-detail.component.html
+++ b/client/src/app/site/motions/modules/motion-block/components/motion-block-detail/motion-block-detail.component.html
@@ -1,10 +1,24 @@
 <os-head-bar [nav]="false">
     <!-- Title -->
     <div class="title-slot">
-        <h2 *ngIf="block">
-            <mat-icon *ngIf="block.internal">lock</mat-icon>
-            {{ block.title }}
-        </h2>
+        <os-icon-container
+            *ngIf="block"
+            [noWrap]="true"
+            icon="check"
+            size="large"
+            [showIcon]="block.isFinished"
+            [iconTooltip]="'Finished' | translate"
+        >
+            <os-icon-container
+                [noWrap]="true"
+                icon="lock"
+                size="large"
+                [showIcon]="block.internal"
+                [iconTooltip]="'Internal' | translate"
+            >
+                <h2>{{ block.title }}</h2>
+            </os-icon-container>
+        </os-icon-container>
     </div>
 
     <!-- Menu -->
diff --git a/client/src/app/site/motions/modules/motion-block/components/motion-block-detail/motion-block-detail.component.ts b/client/src/app/site/motions/modules/motion-block/components/motion-block-detail/motion-block-detail.component.ts
index a581bb0d9..ed54bffa4 100644
--- a/client/src/app/site/motions/modules/motion-block/components/motion-block-detail/motion-block-detail.component.ts
+++ b/client/src/app/site/motions/modules/motion-block/components/motion-block-detail/motion-block-detail.component.ts
@@ -148,6 +148,7 @@ export class MotionBlockDetailComponent extends BaseListViewComponent<ViewMotion
         this.configService
             .get<boolean>('motions_show_sequential_numbers')
             .subscribe(show => (this.showSequential = show));
+        (<any>window).comp = this;
     }
 
     /**
diff --git a/client/src/app/site/motions/modules/motion-block/components/motion-block-list/motion-block-list.component.html b/client/src/app/site/motions/modules/motion-block/components/motion-block-list/motion-block-list.component.html
index 438d82e59..6624b8878 100644
--- a/client/src/app/site/motions/modules/motion-block/components/motion-block-list/motion-block-list.component.html
+++ b/client/src/app/site/motions/modules/motion-block/components/motion-block-list/motion-block-list.component.html
@@ -19,16 +19,28 @@
     <!-- Title column -->
     <div *pblNgridCellDef="'title'; value as title; row as block; rowContext as rowContext" class="cell-slot fill">
         <a class="detail-link" [routerLink]="block.id" *ngIf="!isMultiSelect"></a>
+        <!--
+        TODO: Tooltips do not work when hidden under the absolute link, but they can't be above it either,
+        because for some reason they don't delegate the click event. So no tooltips for now
+        -->
         <div class="innerTable">
             <os-icon-container
                 [noWrap]="true"
-                [icon]="block.internal ? 'lock' : null"
+                [icon]="block.isFinished ? 'check' : block.internal ? 'lock' : null"
                 size="large"
-                [matTooltip]="Internal"
+                [iconTooltip]="block.isFinished ? 'Finished' : block.internal ? 'Internal' : '' | translate"
             >
-                <div class="ellipsis-overflow">
-                    {{ title }}
-                </div>
+                <os-icon-container
+                    [noWrap]="true"
+                    icon="lock"
+                    size="large"
+                    [showIcon]="block.isFinished && block.internal"
+                    [iconTooltip]="'Internal' | translate"
+                >
+                    <div class="ellipsis-overflow">
+                        {{ title }}
+                    </div>
+                </os-icon-container>
             </os-icon-container>
         </div>
     </div>