ag-admin/OpenSlides
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #3953 from ostcar/change_id_fixes

Browse Source 
Add test for second getElement request
This commit is contained in:
Oskar Hahn 2018-10-27 15:06:11 +02:00 committed by GitHub
commit 69e25a57e1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 44 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openslides/utils/cache.py
View File

@ -189,7 +189,9 @@ class ElementCache:
if change_id == 0: if change_id == 0:
return (await self.get_all_full_data(), []) return (await self.get_all_full_data(), [])
# This raises a Runtime Exception, if there is no change_id
lowest_change_id = await self.get_lowest_change_id() lowest_change_id = await self.get_lowest_change_id()
if change_id < lowest_change_id: if change_id < lowest_change_id:
# When change_id is lower then the lowest change_id in redis, we can # When change_id is lower then the lowest change_id in redis, we can
# not inform the user about deleted elements. # not inform the user about deleted elements.

42
tests/integration/utils/test_consumers.py
View File

@ -333,6 +333,48 @@ async def test_send_get_elements_to_small_change_id(communicator):
assert response.get('content')['all_data'] assert response.get('content')['all_data']
@pytest.mark.asyncio
async def test_send_connect_twice_with_clear_change_id_cache(communicator):
"""
Test, that a second request with change_id+1 from the first request, returns
an error.
"""
await set_config('general_system_enable_anonymous', True)
element_cache.cache_provider.change_id_data = {} # type: ignore
await communicator.connect()
await communicator.send_json_to({'type': 'getElements', 'content': {'change_id': 0}, 'id': 'test_id'})
response1 = await communicator.receive_json_from()
first_change_id = response1.get('content')['to_change_id']
await communicator.send_json_to({'type': 'getElements', 'content': {'change_id': first_change_id+1}, 'id': 'test_id'})
response2 = await communicator.receive_json_from()
assert response2['type'] == 'error'
assert response2.get('content') == 'Requested change_id is higher this highest change_id.'
@pytest.mark.asyncio
async def test_send_connect_twice_with_clear_change_id_cache_same_change_id_then_first_request(communicator):
"""
Test, that a second request with the change_id from the first request, returns
all data.
A client should not do this but request for change_id+1
"""
await set_config('general_system_enable_anonymous', True)
element_cache.cache_provider.change_id_data = {} # type: ignore
await communicator.connect()
await communicator.send_json_to({'type': 'getElements', 'content': {'change_id': 0}, 'id': 'test_id'})
response1 = await communicator.receive_json_from()
first_change_id = response1.get('content')['to_change_id']
await communicator.send_json_to({'type': 'getElements', 'content': {'change_id': first_change_id}, 'id': 'test_id'})
response2 = await communicator.receive_json_from()
assert response2['type'] == 'autoupdate'
assert response2.get('content')['all_data']
@pytest.mark.asyncio @pytest.mark.asyncio
async def test_send_invalid_get_elements(communicator): async def test_send_invalid_get_elements(communicator):
await set_config('general_system_enable_anonymous', True) await set_config('general_system_enable_anonymous', True)