More layout fixes for motion diff view slide.

- Fixed wrong text order.
- Improved change summary box.
This commit is contained in:
Emanuel Schütze 2017-02-15 22:14:37 +01:00
parent 8029492d91
commit 7a73b30189
6 changed files with 20 additions and 48 deletions

View File

@ -609,11 +609,11 @@ img {
padding-top: 5px; padding-top: 5px;
} }
.change-recommendation-overview { .change-recommendation-overview {
margin-bottom: 50px; margin-bottom: 30px;
padding: 10px; padding: 10px 15px 0 10px;
} }
.change-recommendation-overview h2 { .change-recommendation-overview h3 {
margin-top: 0; margin-top: 10px;
} }
.change-recommendation-overview ul { .change-recommendation-overview ul {
list-style: none; list-style: none;
@ -628,7 +628,7 @@ img {
} }
.change-recommendation-overview li > * { .change-recommendation-overview li > * {
display: table-cell; display: table-cell;
padding: 4px; padding: 1px;
} }
.change-recommendation-overview .status { .change-recommendation-overview .status {
color: gray; color: gray;

View File

@ -534,12 +534,9 @@ tr.elected td {
} }
.diff-box { .diff-box {
background-color: #f9f9f9; margin-left: 25px;
border: solid 1px #eee;
border-radius: 3px;
margin-bottom: 10px;
padding-top: 0; padding-top: 0;
padding-right: 155px; margin-top: -10px;
} }
.motion-text-with-diffs .original-text { .motion-text-with-diffs .original-text {
min-height: 30px; // Spacer between .diff-box, in case .original-text is empty min-height: 30px; // Spacer between .diff-box, in case .original-text is empty
@ -553,34 +550,6 @@ tr.elected td {
.diff-box:hover { .diff-box:hover {
background-color: #f0f0f0; background-color: #f0f0f0;
} }
.diff-box .action-row {
font-size: 0.8em;
padding-top: 5px;
padding-bottom: 5px;
float: right;
width: 150px;
text-align: right;
margin-right: -150px;
opacity: 0.5;
}
.diff-box:hover .action-row {
opacity: 1;
}
.diff-box .action-row .btn-delete {
margin-left: 5px;
color: red;
}
.diff-box .action-row .btn-edit {
margin-left: 5px;
}
.diff-box .status-row {
font-style: italic;
color: gray;
}
.diff-box .status-row > *:after {
content: ':';
}
.motion-text-diff .delete { .motion-text-diff .delete {
color: red; color: red;
text-decoration: line-through; text-decoration: line-through;

View File

@ -378,6 +378,9 @@
<div ng-class="{'col-sm-8': (lineNumberMode != 'outside'), 'col-sm-12': (lineNumberMode == 'outside')}"> <div ng-class="{'col-sm-8': (lineNumberMode != 'outside'), 'col-sm-12': (lineNumberMode == 'outside')}">
<ng-include ng-if="viewChangeRecommendations.mode == 'diff'"
src="'static/templates/motions/motion-detail/change-summary.html'"></ng-include>
<div><p>{{ config('motions_preamble') | translate }}</p></div> <div><p>{{ config('motions_preamble') | translate }}</p></div>
<div class="motion-text-holder"> <div class="motion-text-holder">

View File

@ -1,11 +1,11 @@
<!-- A summary of all changes --> <!-- A summary of all changes -->
<section class="change-recommendation-overview"> <section class="change-recommendation-overview">
<h2> <strong>
<translate>Summary of change recommendations</translate> <translate>Summary of change recommendations</translate>:
</h2> </strong>
<ul ng-if="change_recommendations.length > 0"> <ul ng-if="change_recommendations.length > 0">
<li ng-repeat="change in (changes = (change_recommendations | filter:{motion_version_id:version}:true | orderBy: 'line_from')) " <li ng-repeat="change in (changes = (change_recommendations | filter:{motion_version_id:version}:true | orderBy: 'line_from')) ">
ng-click="viewChangeRecommendations.scrollToDiffBox(change.id)"> <a href='' ng-click="viewChangeRecommendations.scrollToDiffBox(change.id)">
<span ng-if="change.line_from >= change.line_to - 1" class="line-number"> <span ng-if="change.line_from >= change.line_to - 1" class="line-number">
<translate>Line</translate> {{ change.line_from }}: <translate>Line</translate> {{ change.line_from }}:
</span> </span>
@ -20,6 +20,7 @@
<span class="status"> <span class="status">
<translate ng-if="change.rejected">Rejected</translate> <translate ng-if="change.rejected">Rejected</translate>
</span> </span>
</a>
</li> </li>
</ul> </ul>
<div ng-if="change_recommendations.length == 0" class="no-changes"> <div ng-if="change_recommendations.length == 0" class="no-changes">

View File

@ -1,5 +1,4 @@
<div ng-if="viewChangeRecommendations.mode == 'diff'"> <div ng-if="viewChangeRecommendations.mode == 'diff'">
<ng-include src="'static/templates/motions/motion-detail/change-summary.html'"></ng-include>
<!-- The actual diff view --> <!-- The actual diff view -->
<div class="motion-text-with-diffs line-numbers-{{ lineNumberMode }}"> <div class="motion-text-with-diffs line-numbers-{{ lineNumberMode }}">

View File

@ -103,11 +103,11 @@
ng-bind-html="change.getDiff(motion, null, line) | trusted"> ng-bind-html="change.getDiff(motion, null, line) | trusted">
</div> </div>
</div> </div>
<div class="motion-text original-text line-numbers-{{ config('motions_default_line_numbering') }}"
ng-bind-html="motion.getTextRemainderAfterLastChangeRecommendation(null, changes, line) | trusted">
</div>
</div> </div>
<div class="motion-text original-text line-numbers-{{ config('motions_default_line_numbering') }}"
ng-bind-html="motion.getTextRemainderAfterLastChangeRecommendation(null, changes, line) | trusted">
</div>
</div> </div>
</div> </div>