From 7bff79b377ccef82bf3f2a00f68de6cf93214b72 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Norman=20J=C3=A4ckel?= <openslides@normanjaeckel.de>
Date: Wed, 25 Nov 2015 10:48:33 +0100
Subject: [PATCH] Added manager to number all agenda items.

---
 openslides/agenda/models.py | 63 +++++++++++++++++--------------------
 openslides/agenda/views.py  |  5 ++-
 2 files changed, 31 insertions(+), 37 deletions(-)

diff --git a/openslides/agenda/models.py b/openslides/agenda/models.py
index 9bcc5d795..b0476273e 100644
--- a/openslides/agenda/models.py
+++ b/openslides/agenda/models.py
@@ -17,6 +17,10 @@ from openslides.utils.utils import to_roman
 
 
 class ItemManager(models.Manager):
+    """
+    Customized model manager with special methods for agenda tree and
+    numbering.
+    """
     def get_only_agenda_items(self, queryset=None):
         """
         Generator, which yields only agenda items. Skips hidden items.
@@ -36,14 +40,14 @@ class ItemManager(models.Manager):
                 yield from yield_items(item_children[item.pk])
         yield from yield_items(root_items)
 
-    def get_root_and_children(self, queryset=None, only_agenda_items=False):
+    def get_root_and_children(self, only_agenda_items=False):
         """
         Returns a list with all root items and a dictonary where the key is an
         item pk and the value is a list with all children of the item.
-        """
-        if queryset is None:
-            queryset = self.order_by('weight')
 
+        If only_agenda_items is True, the tree hides HIDDEN_ITEM.
+        """
+        queryset = self.order_by('weight')
         item_children = defaultdict(list)
         root_items = []
         for item in queryset:
@@ -62,7 +66,7 @@ class ItemManager(models.Manager):
         and children, where id is the id of one agenda item and children is a
         generator that yields dictonaries like the one discribed.
 
-        If only_agenda_items is True, the tree hides ORGANIZATIONAL_ITEMs.
+        If only_agenda_items is True, the tree hides HIDDEN_ITEM.
 
         If include_content is True, the yielded dictonaries have no key 'id'
         but a key 'item' with the entire object.
@@ -121,6 +125,26 @@ class ItemManager(models.Manager):
                 db_item.weight = weight
                 db_item.save()
 
+    @transaction.atomic
+    def number_all(self, numeral_system='arabic'):
+        """
+        Auto numbering of the agenda according to the numeral_system. Manually
+        added item numbers will be overwritten.
+        """
+        def walk_tree(tree, number=None):
+            for index, tree_element in enumerate(tree):
+                if numeral_system == 'roman' and number is None:
+                    item_number = to_roman(index + 1)
+                else:
+                    item_number = str(index + 1)
+                    if number is not None:
+                        item_number = '.'.join((number, item_number))
+                tree_element['item'].item_number = item_number
+                tree_element['item'].save()
+                walk_tree(tree_element['children'], item_number)
+
+        walk_tree(self.get_tree(only_agenda_items=True, include_content=True))
+
 
 class Item(RESTModelMixin, models.Model):
     """
@@ -263,35 +287,6 @@ class Item(RESTModelMixin, models.Model):
                 item_no = str(self.item_number)
         return item_no
 
-    def calc_item_no(self):
-        """
-        Returns the number of this agenda item.
-        """
-        if not self.is_hidden():
-            if self.parent is None:
-                sibling_no = self.sibling_no()
-                if config['agenda_numeral_system'] == 'arabic':
-                    return str(sibling_no)
-                else:  # config['agenda_numeral_system'] == 'roman'
-                    return to_roman(sibling_no)
-            else:
-                return '%s.%s' % (self.parent.calc_item_no(), self.sibling_no())
-        else:
-            return ''
-
-    def sibling_no(self):
-        """
-        Counts how many agenda items with the same parent (siblings) have a
-        smaller weight then this item.
-
-        Returns this number + 1.
-        """
-        result = 0
-        for item in Item.objects.filter(parent=self.parent, weight__lte=self.weight):
-            if not item.is_hidden():
-                result += 1
-        return result
-
 
 class SpeakerManager(models.Manager):
     """
diff --git a/openslides/agenda/views.py b/openslides/agenda/views.py
index 0d7555bf5..2202ae970 100644
--- a/openslides/agenda/views.py
+++ b/openslides/agenda/views.py
@@ -5,6 +5,7 @@ from django.utils.translation import ugettext as _
 from django.utils.translation import ugettext_lazy
 from reportlab.platypus import Paragraph
 
+from openslides.core.config import config
 from openslides.utils.exceptions import OpenSlidesError
 from openslides.utils.pdf import stylesheet
 from openslides.utils.rest_api import (
@@ -225,9 +226,7 @@ class ItemViewSet(ListModelMixin, RetrieveModelMixin, UpdateModelMixin, GenericV
         Auto numbering of the agenda according to the config. Manually added
         item numbers will be overwritten.
         """
-        for item in Item.objects.all():
-            item.item_number = item.calc_item_no()
-            item.save()
+        Item.objects.number_all(numeral_system=config['agenda_numeral_system'])
         return Response({'detail': _('The agenda has been numbered.')})