Merge pull request #5534 from tsiegleauq/protected-values-cause-user-error

Cleanup previous return statements in void functions
This commit is contained in:
Sean 2020-09-28 11:53:57 +02:00 committed by GitHub
commit 991c08d57d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 6 deletions

View File

@ -500,20 +500,17 @@ export class UserRepositoryService extends BaseRepository<ViewUser, User, UserTi
}
private preventAlterationOnDemoUsers(users: ViewUser | ViewUser[]): void {
if (!this.demoModeUserIds) {
return;
}
if (Array.isArray(users)) {
if (users.map(user => user.id).intersect(this.demoModeUserIds).length > 0) {
if (this.demoModeUserIds && users.map(user => user.id).intersect(this.demoModeUserIds).length > 0) {
this.preventInDemo();
}
} else if (this.demoModeUserIds.some(userId => userId === users.id)) {
} else if (this.demoModeUserIds?.some(userId => userId === users.id)) {
this.preventInDemo();
}
}
private preventInDemo(): void {
if (this.demoModeUserIds) {
if (this.demoModeUserIds && this.demoModeUserIds.length) {
throw new PreventedInDemo();
}
}