From 1e45153c0a6bf54bd678f02aefd04e91c4a7705b Mon Sep 17 00:00:00 2001
From: Sean Engelhardt <sean.f.t.engelhardt@gmail.com>
Date: Tue, 10 Dec 2019 16:46:59 +0100
Subject: [PATCH] Fix untranslated searchable values

Fixes a bug where the search value selector was not always filtering
for translated values.
Uses getTitle() in SearchValue selector rather than toString,
to allow enhance compatibility with custom values
---
 .../search-value-selector.component.ts                   | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/client/src/app/shared/components/search-value-selector/search-value-selector.component.ts b/client/src/app/shared/components/search-value-selector/search-value-selector.component.ts
index db48c1134..d01428439 100644
--- a/client/src/app/shared/components/search-value-selector/search-value-selector.component.ts
+++ b/client/src/app/shared/components/search-value-selector/search-value-selector.component.ts
@@ -152,13 +152,8 @@ export class SearchValueSelectorComponent implements OnDestroy {
                 if (foundId) {
                     return true;
                 }
-
-                return (
-                    item
-                        .toString()
-                        .toLowerCase()
-                        .indexOf(this.searchValue) > -1
-                );
+                const searchableString = this.translate.instant(item.getTitle()).toLowerCase();
+                return searchableString.indexOf(this.searchValue) > -1;
             });
         }
     }