From c3c98f06e3966f7a142df9283200ab3911289bce Mon Sep 17 00:00:00 2001 From: Sean Engelhardt Date: Wed, 22 May 2019 18:35:58 +0200 Subject: [PATCH] Fixes an issue where sorting was tried with undefined valued Hot-Fixes agenda sorting --- .../repositories/agenda/item-repository.service.ts | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/client/src/app/core/repositories/agenda/item-repository.service.ts b/client/src/app/core/repositories/agenda/item-repository.service.ts index 7c22d2a3a..f0878f394 100644 --- a/client/src/app/core/repositories/agenda/item-repository.service.ts +++ b/client/src/app/core/repositories/agenda/item-repository.service.ts @@ -57,7 +57,15 @@ export class ItemRepositoryService extends BaseRepository { MotionBlock ]); - this.setSortFunction((a, b) => a.weight - b.weight); + this.setSortFunction((a, b) => { + // TODO: In some occasions weight will be undefined, if the user has not the correct set of permission. + // That should not be the case here. + if (a.weight && b.weight) { + return a.weight - b.weight; + } else { + return -1; + } + }); } public getVerboseName = (plural: boolean = false) => {