Merge pull request #3914 from normanjaeckel/PasswordResetEMail

Added PasswordResetView.

CHANGELOG.rst

@@ -18,7 +18,8 @@ Core:
    mode [#3799, #3817].
  - Changed format for elements send via autoupdate [#3926].
  - Add a change-id system to get only new elements [#3938].
- - Switch from Yarn back to npm.
+ - Switch from Yarn back to npm [#3964].
+ - Added password reset link (password reset via email) [#3914].
 
 Motions:
  - Option to customly sort motions [#3894].

client/src/app/app-routing.module.ts

@@ -1,10 +1,12 @@
 import { NgModule } from '@angular/core';
 import { RouterModule, Routes } from '@angular/router';
 
-import { LoginComponent } from './site/login/components/login-wrapper/login.component';
+import { LoginWrapperComponent } from './site/login/components/login-wrapper/login-wrapper.component';
 import { LoginMaskComponent } from './site/login/components/login-mask/login-mask.component';
 import { LoginLegalNoticeComponent } from './site/login/components/login-legal-notice/login-legal-notice.component';
 import { LoginPrivacyPolicyComponent } from './site/login/components/login-privacy-policy/login-privacy-policy.component';
+import { ResetPasswordComponent } from './site/login/components/reset-password/reset-password.component';
+import { ResetPasswordConfirmComponent } from './site/login/components/reset-password-confirm/reset-password-confirm.component';
 
 /**
  * Global app routing
@@ -12,9 +14,11 @@ import { LoginPrivacyPolicyComponent } from './site/login/components/login-priva
 const routes: Routes = [
     {
         path: 'login',
-        component: LoginComponent,
+        component: LoginWrapperComponent,
         children: [
             { path: '', component: LoginMaskComponent },
+            { path: 'reset-password', component: ResetPasswordComponent },
+            { path: 'reset-password-confirm', component: ResetPasswordConfirmComponent },
             { path: 'legalnotice', component: LoginLegalNoticeComponent },
             { path: 'privacypolicy', component: LoginPrivacyPolicyComponent }
         ]

client/src/app/site/login/assets/reset-password-pages.scss

@@ -0,0 +1,30 @@
+h3 {
+    margin-top: 0;
+    font-weight: normal;
+}
+
+mat-form-field {
+    width: 100%;
+}
+
+.submit-button {
+    margin-top: 30px;
+    width: 60%;
+    margin-left: auto;
+    margin-right: auto;
+}
+
+.back-button {
+    width: 40%;
+}
+
+.form-wrapper {
+    padding-left: 30px;
+    padding-right: 30px;
+}
+
+form {
+    padding-top: 50px;
+    margin: 0 auto;
+    max-width: 400px;
+}

client/src/app/site/login/components/login-legal-notice/login-legal-notice.component.ts

@@ -7,7 +7,7 @@ import { Component, OnInit } from '@angular/core';
 @Component({
     selector: 'os-login-legal-notice',
     templateUrl: './login-legal-notice.component.html',
-    styleUrls: ['./login-legal-notice.component.scss', '../../assets/login-info-pages.scss']
+    styleUrls: ['../../assets/login-info-pages.scss']
 })
 export class LoginLegalNoticeComponent implements OnInit {
     /**

client/src/app/site/login/components/login-mask/login-mask.component.scss

@@ -28,7 +28,7 @@ mat-form-field {
 }
 
 .login-form {
-    padding-top: 60px;
+    padding-top: 50px;
     margin: 0 auto;
     max-width: 400px;
 }

client/src/app/site/login/components/login-mask/login-mask.component.ts

@@ -1,5 +1,5 @@
 import { Component, OnInit, OnDestroy } from '@angular/core';
-import { Router } from '@angular/router';
+import { Router, ActivatedRoute } from '@angular/router';
 
 import { BaseComponent } from 'app/base.component';
 import { AuthService } from 'app/core/services/auth.service';
@@ -72,6 +72,7 @@ export class LoginMaskComponent extends BaseComponent implements OnInit, OnDestr
         private authService: AuthService,
         private operator: OperatorService,
         private router: Router,
+        private route: ActivatedRoute,
         private formBuilder: FormBuilder,
         private http: HttpService,
         private matSnackBar: MatSnackBar,
@@ -151,10 +152,10 @@ export class LoginMaskComponent extends BaseComponent implements OnInit, OnDestr
     }
 
     /**
-     * TODO, should open an edit view for the users password.
+     * Go to the reset password view
      */
     public resetPassword(): void {
-        console.log('TODO');
+        this.router.navigate(['./reset-password'], { relativeTo: this.route });
     }
 
     /**

client/src/app/site/login/components/login-privacy-policy/login-privacy-policy.component.ts

@@ -7,7 +7,7 @@ import { Component, OnInit } from '@angular/core';
 @Component({
     selector: 'os-login-privacy-policy',
     templateUrl: './login-privacy-policy.component.html',
-    styleUrls: ['./login-privacy-policy.component.scss', '../../assets/login-info-pages.scss']
+    styleUrls: ['../../assets/login-info-pages.scss']
 })
 export class LoginPrivacyPolicyComponent implements OnInit {
     /**

client/src/app/site/login/components/login-wrapper/login-wrapper.component.spec.ts

@@ -1,11 +1,11 @@
 import { async, ComponentFixture, TestBed } from '@angular/core/testing';
 
-import { LoginComponent } from './login.component';
-import { E2EImportsModule } from '../../../../../e2e-imports.module';
+import { LoginWrapperComponent } from './login-wrapper.component';
+import { E2EImportsModule } from 'e2e-imports.module';
 
 describe('LoginComponent', () => {
-    let component: LoginComponent;
-    let fixture: ComponentFixture<LoginComponent>;
+    let component: LoginWrapperComponent;
+    let fixture: ComponentFixture<LoginWrapperComponent>;
 
     beforeEach(async(() => {
         TestBed.configureTestingModule({
@@ -14,7 +14,7 @@ describe('LoginComponent', () => {
     }));
 
     beforeEach(() => {
-        fixture = TestBed.createComponent(LoginComponent);
+        fixture = TestBed.createComponent(LoginWrapperComponent);
         component = fixture.componentInstance;
         fixture.detectChanges();
     });

client/src/app/site/login/components/login-wrapper/login-wrapper.component.ts

@@ -7,14 +7,14 @@ import { BaseComponent } from '../../../../base.component';
 /**
  * Login component.
  *
- * Serves as container for the login mask, legal notice and privacy policy
+ * Serves as container for the login mask, reset password (confirm) form, legal notice and privacy policy
  */
 @Component({
-    selector: 'os-login',
-    templateUrl: './login.component.html',
-    styleUrls: ['./login.component.scss']
+    selector: 'os-login-wrapper',
+    templateUrl: './login-wrapper.component.html',
+    styleUrls: ['./login-wrapper.component.scss']
 })
-export class LoginComponent extends BaseComponent implements OnInit {
+export class LoginWrapperComponent extends BaseComponent implements OnInit {
     /**
      * Imports the title service and the translate service
      *

client/src/app/site/login/components/reset-password-confirm/reset-password-confirm.component.html

@@ -0,0 +1,15 @@
+<div class="form-wrapper">
+    <form [formGroup]="newPasswordForm" (ngSubmit)="submitNewPassword()">
+        <h3 translate>Please enter your new password</h3>
+        <mat-form-field>
+            <input matInput required placeholder="{{ 'New password' | translate }}" formControlName="password" type="password">
+            <mat-error *ngIf="newPasswordForm.get('password').hasError('required')" translate>
+                A password is required
+            </mat-error>
+        </mat-form-field>
+        <br>
+        <button mat-raised-button color="primary" class='submit-button' [disabled]="newPasswordForm.invalid"
+            type="submit" translate>Reset password</button>
+        <button mat-button class="back-button" routerLink="/login" translate>Back to login</button>
+    </form>
+</div>

client/src/app/site/login/components/reset-password-confirm/reset-password-confirm.component.spec.ts

@@ -0,0 +1,46 @@
+import { async, ComponentFixture, TestBed, tick, fakeAsync, flush, flushMicrotasks } from '@angular/core/testing';
+
+import { ResetPasswordConfirmComponent } from './reset-password-confirm.component';
+import { E2EImportsModule } from 'e2e-imports.module';
+import { MatSnackBar } from '@angular/material';
+
+let matSnackBarSpy: jasmine.SpyObj<MatSnackBar>;
+
+describe('ResetPasswordConfirmComponent', () => {
+    let component: ResetPasswordConfirmComponent;
+    let fixture: ComponentFixture<ResetPasswordConfirmComponent>;
+
+    beforeEach(async(() => {
+        const spy = jasmine.createSpyObj('MatSnackBar', ['open']);
+
+        TestBed.configureTestingModule({
+            imports: [E2EImportsModule],
+            providers: [
+                {provide: MatSnackBar, useValue: spy}
+            ]
+        }).compileComponents();
+        matSnackBarSpy = TestBed.get(MatSnackBar)
+    }));
+
+    beforeEach(() => {
+        fixture = TestBed.createComponent(ResetPasswordConfirmComponent);
+        component = fixture.componentInstance;
+        fixture.detectChanges();
+    });
+
+    it('should create', () => {
+        expect(component).toBeTruthy();
+    });
+
+    xit('should open a snackbar error', fakeAsync(() => {
+        // WTF? I do not kno what to do more, but the expect should run after the set timeout...
+        fixture.detectChanges();
+        tick();
+        fixture.detectChanges();
+        flush();
+        fixture.detectChanges();
+        flushMicrotasks();
+        fixture.detectChanges();
+        expect(matSnackBarSpy.open.calls.count()).toBe(1, 'mat snack bar was opened');
+    }));
+});

client/src/app/site/login/components/reset-password-confirm/reset-password-confirm.component.ts

@@ -0,0 +1,109 @@
+import { Component, OnInit } from '@angular/core';
+import { Title } from '@angular/platform-browser';
+import { TranslateService } from '@ngx-translate/core';
+
+import { BaseComponent } from '../../../../base.component';
+import { FormGroup, FormBuilder, Validators } from '@angular/forms';
+import { HttpClient } from '@angular/common/http';
+import { environment } from 'environments/environment';
+import { ActivatedRoute, Router } from '@angular/router';
+import { MatSnackBar } from '@angular/material';
+
+/**
+ * Reset password component.
+ *
+ */
+@Component({
+    selector: 'os-reset-password-confirm',
+    templateUrl: './reset-password-confirm.component.html',
+    styleUrls: ['../../assets/reset-password-pages.scss']
+})
+export class ResetPasswordConfirmComponent extends BaseComponent implements OnInit {
+    /**
+     * THis form holds one control for the new password.
+     */
+    public newPasswordForm: FormGroup;
+
+    /**
+     * The user_id that should be provided in the queryparams.
+     */
+    private user_id: string;
+
+    /**
+     * The token that should be provided in the queryparams.
+     */
+    private token: string;
+
+    /**
+     * Constructur for the reset password confirm view. Initializes the form for the new password.
+     */
+    public constructor(
+        protected titleService: Title,
+        protected translate: TranslateService,
+        private http: HttpClient,
+        formBuilder: FormBuilder,
+        private activatedRoute: ActivatedRoute,
+        private router: Router,
+        private matSnackBar: MatSnackBar
+    ) {
+        super(titleService, translate);
+        this.newPasswordForm = formBuilder.group({
+            password: ['', [Validators.required]]
+        });
+    }
+
+    /**
+     * Sets the title of the page and gets the queryparams.
+     */
+    public ngOnInit(): void {
+        super.setTitle('Reset password');
+        this.activatedRoute.queryParams.subscribe(params => {
+            if (!params.user_id || !params.token) {
+                setTimeout(() => {
+                    this.matSnackBar.open('');
+                    this.matSnackBar.open(
+                        this.translate.instant('The link is broken. Please contact your system administrator.'),
+                        this.translate.instant('OK'),
+                        {
+                            duration: 0
+                        }
+                    );
+                    this.router.navigate(['/']);
+                });
+            } else {
+                this.user_id = params.user_id;
+                this.token = params.token;
+            }
+        });
+    }
+
+    /**
+     * Submit the new password.
+     */
+    public async submitNewPassword(): Promise<void> {
+        if (this.newPasswordForm.invalid) {
+            return;
+        }
+
+        try {
+            await this.http
+                .post<void>(environment.urlPrefix + '/users/reset-password-confirm/', {
+                    user_id: this.user_id,
+                    token: this.token,
+                    password: this.newPasswordForm.get('password').value
+                })
+                .toPromise();
+            // TODO: Does we get a response for displaying?
+            this.matSnackBar.open(
+                this.translate.instant('Your password was resetted successfully!'),
+                this.translate.instant('OK'),
+                {
+                    duration: 0
+                }
+            );
+            this.router.navigate(['/login']);
+        } catch (e) {
+            console.log('error', e);
+        }
+    }
+}

client/src/app/site/login/components/reset-password/reset-password.component.html

@@ -0,0 +1,15 @@
+<div class="form-wrapper">
+    <form [formGroup]="resetPasswordForm" (ngSubmit)="resetPassword()">
+        <h3 translate>Enter your email to send the password reset link</h3>
+        <mat-form-field>
+            <input matInput required placeholder="Email" formControlName="email" type="email">
+            <mat-error *ngIf="resetPasswordForm.get('email').hasError('email')" translate>
+                Please enter a valid email address
+            </mat-error>
+        </mat-form-field>
+        <br>
+        <button mat-raised-button color="primary" class='submit-button' [disabled]="resetPasswordForm.invalid"
+            type="submit" translate>Reset password</button>
+        <button mat-button class="back-button" routerLink="/login" translate>Back to login</button>
+    </form>
+</div>

client/src/app/site/login/components/reset-password/reset-password.component.spec.ts

@@ -0,0 +1,25 @@
+import { async, ComponentFixture, TestBed } from '@angular/core/testing';
+
+import { ResetPasswordComponent } from './reset-password.component';
+import { E2EImportsModule } from 'e2e-imports.module';
+
+describe('ResetPasswordComponent', () => {
+    let component: ResetPasswordComponent;
+    let fixture: ComponentFixture<ResetPasswordComponent>;
+
+    beforeEach(async(() => {
+        TestBed.configureTestingModule({
+            imports: [E2EImportsModule]
+        }).compileComponents();
+    }));
+
+    beforeEach(() => {
+        fixture = TestBed.createComponent(ResetPasswordComponent);
+        component = fixture.componentInstance;
+        fixture.detectChanges();
+    });
+
+    it('should create', () => {
+        expect(component).toBeTruthy();
+    });
+});

client/src/app/site/login/components/reset-password/reset-password.component.ts

@@ -0,0 +1,78 @@
+import { Component, OnInit } from '@angular/core';
+import { Title } from '@angular/platform-browser';
+import { TranslateService } from '@ngx-translate/core';
+
+import { BaseComponent } from '../../../../base.component';
+import { FormGroup, FormBuilder, Validators } from '@angular/forms';
+import { HttpClient } from '@angular/common/http';
+import { environment } from 'environments/environment';
+import { MatSnackBar } from '@angular/material';
+import { Router } from '@angular/router';
+
+/**
+ * Reset password component.
+ *
+ */
+@Component({
+    selector: 'os-reset-password',
+    templateUrl: './reset-password.component.html',
+    styleUrls: ['../../assets/reset-password-pages.scss']
+})
+export class ResetPasswordComponent extends BaseComponent implements OnInit {
+    /**
+     * THis form holds one control for the email.
+     */
+    public resetPasswordForm: FormGroup;
+
+    /**
+     * Constructur for the reset password view. Initializes the form for the email.
+     */
+    public constructor(
+        protected titleService: Title,
+        protected translate: TranslateService,
+        private http: HttpClient,
+        formBuilder: FormBuilder,
+        private matSnackBar: MatSnackBar,
+        private router: Router
+    ) {
+        super(titleService, translate);
+        this.resetPasswordForm = formBuilder.group({
+            email: ['', [Validators.required, Validators.email]]
+        });
+    }
+
+    /**
+     * sets the title of the page
+     */
+    public ngOnInit(): void {
+        super.setTitle('Reset password');
+    }
+
+    /**
+     * Do the password reset.
+     */
+    public async resetPassword(): Promise<void> {
+        if (this.resetPasswordForm.invalid) {
+            return;
+        }
+
+        try {
+            await this.http
+                .post<void>(environment.urlPrefix + '/users/reset-password/', {
+                    email: this.resetPasswordForm.get('email').value
+                })
+                .toPromise();
+            // TODO: Does we get a response for displaying?
+            this.matSnackBar.open(
+                this.translate.instant('An email with a password reset link was send!'),
+                this.translate.instant('OK'),
+                {
+                    duration: 0
+                }
+            );
+            this.router.navigate(['/login']);
+        } catch (e) {
+            console.log('error', e);
+        }
+    }
+}

client/src/app/site/login/login.module.ts

@@ -2,14 +2,23 @@ import { NgModule } from '@angular/core';
 import { CommonModule } from '@angular/common';
 import { RouterModule } from '@angular/router';
 
-import { LoginComponent } from './components/login-wrapper/login.component';
+import { LoginWrapperComponent } from './components/login-wrapper/login-wrapper.component';
 import { SharedModule } from '../../shared/shared.module';
 import { LoginMaskComponent } from './components/login-mask/login-mask.component';
 import { LoginLegalNoticeComponent } from './components/login-legal-notice/login-legal-notice.component';
 import { LoginPrivacyPolicyComponent } from './components/login-privacy-policy/login-privacy-policy.component';
+import { ResetPasswordComponent } from './components/reset-password/reset-password.component';
+import { ResetPasswordConfirmComponent } from './components/reset-password-confirm/reset-password-confirm.component';
 
 @NgModule({
     imports: [CommonModule, RouterModule, SharedModule],
-    declarations: [LoginComponent, LoginMaskComponent, LoginLegalNoticeComponent, LoginPrivacyPolicyComponent]
+    declarations: [
+        LoginWrapperComponent,
+        ResetPasswordComponent,
+        ResetPasswordConfirmComponent,
+        LoginMaskComponent,
+        LoginLegalNoticeComponent,
+        LoginPrivacyPolicyComponent
+    ]
 })
 export class LoginModule {}

client/src/app/site/users/components/user-detail/user-detail.component.html

@@ -64,7 +64,7 @@
         </div>
 
         <div>
-            <!-- Strcuture Level -->
+            <!-- Strucuture Level -->
             <mat-form-field class='form70 distance' *ngIf='user.structure_level || editUser && isAllowed("manage")'>
                 <input type='text' matInput placeholder='{{"Structure Level" | translate}}' formControlName='structure_level'
                     [value]='user.structure_level'>

openslides/users/urls.py

@@ -20,4 +20,12 @@ urlpatterns = [
     url(r'^setpassword/$',
         views.SetPasswordView.as_view(),
         name='user_setpassword'),
+
+    url(r'^reset-password/$',
+        views.PasswordResetView.as_view(),
+        name='user_reset_password'),
+
+    url(r'^reset-password-confirm/$',
+        views.PasswordResetConfirmView.as_view(),
+        name='password_reset_confirm'),
 ]

openslides/users/views.py

@@ -1,4 +1,5 @@
 import smtplib
+import textwrap
 from typing import List
 
 from asgiref.sync import async_to_sync
@@ -10,10 +11,13 @@ from django.contrib.auth import (
 )
 from django.contrib.auth.forms import AuthenticationForm
 from django.contrib.auth.password_validation import validate_password
+from django.contrib.auth.tokens import default_token_generator
+from django.contrib.sites.shortcuts import get_current_site
 from django.core import mail
 from django.core.exceptions import ValidationError as DjangoValidationError
 from django.db import transaction
-from django.utils.encoding import force_text
+from django.utils.encoding import force_bytes, force_text
+from django.utils.http import urlsafe_base64_decode, urlsafe_base64_encode
 from django.utils.translation import ugettext as _
 
 from ..core.config import config
@@ -529,3 +533,113 @@ class SetPasswordView(APIView):
         else:
             raise ValidationError({'detail': _('Old password does not match.')})
         return super().post(request, *args, **kwargs)
+
+
+class PasswordResetView(APIView):
+    """
+    Users can send an email to themselves to get a password reset email.
+
+    Send POST request with {'email': <email addresss>} and all users with this
+    address will receive an email (means Django sends one or more emails to
+    this address) with a one-use only link.
+    """
+    http_method_names = ['post']
+    use_https = False  # TODO: Do we use https?
+
+    def post(self, request, *args, **kwargs):
+        """
+        Loop over all users and send emails.
+        """
+        to_email = request.data.get('email')
+        for user in self.get_users(to_email):
+            current_site = get_current_site(request)
+            site_name = current_site.name
+            context = {
+                'email': to_email,
+                'site_name': site_name,
+                'protocol': 'https' if self.use_https else 'http',
+                'domain': current_site.domain,
+                'path': '/login/reset-password-confirm/',
+                'user_id': urlsafe_base64_encode(force_bytes(user.pk)).decode(),
+                'token': default_token_generator.make_token(user),
+                'username': user.get_username(),
+            }
+            # Send a django.core.mail.EmailMessage to `to_email`.
+            subject = _('Password reset for {}').format(site_name)
+            subject = ''.join(subject.splitlines())
+            body = self.get_email_body(**context)
+            from_email = None  # TODO: Add nice from_email here.
+            email_message = mail.EmailMessage(subject, body, from_email, [to_email])
+            email_message.send()
+        return super().post(request, *args, **kwargs)
+
+    def get_users(self, email):
+        """Given an email, return matching user(s) who should receive a reset.
+
+        This allows subclasses to more easily customize the default policies
+        that prevent inactive users and users with unusable passwords from
+        resetting their password.
+        """
+        active_users = User.objects.filter(**{
+            'email__iexact': email,
+            'is_active': True,
+        })
+        return (u for u in active_users if u.has_usable_password())
+
+    def get_email_body(self, **context):
+        """
+        Add context to email template and return the complete body.
+        """
+        return textwrap.dedent(
+            """
+            You're receiving this email because you requested a password reset for your user account at {site_name}.
+
+            Please go to the following page and choose a new password:
+
+            {protocol}://{domain}{path}?user_id={user_id}&token={token}
+
+            Your username, in case you've forgotten: {username}
+
+            Thanks for using our site!
+
+            The {site_name} team.
+            """
+        ).format(**context)
+
+
+class PasswordResetConfirmView(APIView):
+    """
+    View to reset the password.
+
+    Send POST request with {'user_id': <encoded user id>, 'token': <token>,
+    'password' <new password>} to set password of this user to the new one.
+    """
+    http_method_names = ['post']
+
+    def post(self, request, *args, **kwargs):
+        uidb64 = request.data.get('user_id')
+        token = request.data.get('token')
+        password = request.data.get('password')
+        if not (uidb64 and token and password):
+            raise ValidationError({'detail': _('You have to provide user_id, token and password.')})
+        user = self.get_user(uidb64)
+        if user is None:
+            raise ValidationError({'detail': _('User does not exist.')})
+        if not default_token_generator.check_token(user, token):
+            raise ValidationError({'detail': _('Invalid token.')})
+        try:
+            validate_password(password, user=user)
+        except DjangoValidationError as errors:
+            raise ValidationError({'detail': ' '.join(errors)})
+        user.set_password(password)
+        user.save()
+        return super().post(request, *args, **kwargs)
+
+    def get_user(self, uidb64):
+        try:
+            # urlsafe_base64_decode() decodes to bytestring
+            uid = urlsafe_base64_decode(uidb64).decode()
+            user = User.objects.get(pk=uid)
+        except (TypeError, ValueError, OverflowError, User.DoesNotExist):
+            user = None
+        return user