Fix recommendations from code review

This commit is contained in:
Ralf Peschke 2021-02-18 16:49:21 +01:00
parent d413f04585
commit f3086375cc
7 changed files with 57 additions and 77 deletions

View File

@ -260,15 +260,13 @@
"permissions": [ "permissions": [
"agenda_item.can_see_internal", "agenda_item.can_see_internal",
"assignment.can_see", "assignment.can_see",
"meeting.can_see_frontpage",
"projector.can_see",
"mediafile.can_see",
"motion.can_see",
"user.can_see",
# Missing compared with os3 and existing permissions in models.yml
"list_of_speakers.can_see", "list_of_speakers.can_see",
"user.can_change_own_password", "mediafile.can_see",
"meeting.can_see_frontpage",
"motion.can_see",
"projector.can_see",
"user.can_see",
"user.can_change_own_password"
], ],
"user_ids": [], "user_ids": [],
@ -307,20 +305,18 @@
"name": "Staff", "name": "Staff",
"permissions": [ "permissions": [
"agenda_item.can_manage", "agenda_item.can_manage",
"list_of_speakers.can_be_speaker",
"assignment.can_manage", "assignment.can_manage",
"assignment.can_nominate_self", "assignment.can_nominate_self",
"projector.can_manage", "list_of_speakers.can_be_speaker",
"meeting.can_see_frontpage",
"tag.can_manage",
"mediafile.can_manage",
"motion.can_manage",
"user.can_manage",
# Missing compared with os3 and existing permissions in models.yml
"list_of_speakers.can_manage", "list_of_speakers.can_manage",
"mediafile.can_manage",
"meeting.can_see_frontpage",
"meeting.can_see_history", "meeting.can_see_history",
"user.can_change_own_password", "motion.can_manage",
"projector.can_manage",
"tag.can_manage",
"user.can_manage",
"user.can_change_own_password"
], ],
"user_ids": [], "user_ids": [],
@ -342,17 +338,14 @@
"permissions": [ "permissions": [
"agenda_item.can_see_internal", "agenda_item.can_see_internal",
"assignment.can_see", "assignment.can_see",
"meeting.can_see_frontpage",
"projector.can_see",
"mediafile.can_see",
"motion.can_create",
"motion.can_support",
"user.can_see"
# Missing permissions compared with os3 and existing permissions in models.yml
"list_of_speakers.can_see", "list_of_speakers.can_see",
"mediafile.can_see",
"meeting.can_see_frontpage",
"motion.can_create",
"motion.can_create_amendments", "motion.can_create_amendments",
"user.can_see_extra_data", "motion.can_support",
"user.can_change_own_password", "projector.can_see",
"user.can_see"
], ],
"user_ids": [], "user_ids": [],
@ -373,24 +366,18 @@
"name": "Delegates", "name": "Delegates",
"permissions": [ "permissions": [
"agenda_item.can_see_internal", "agenda_item.can_see_internal",
"list_of_speakers.can_be_speaker",
"assignment.can_nominate_other", "assignment.can_nominate_other",
"assignment.can_nominate_self", "assignment.can_nominate_self",
"meeting.can_see_frontpage", "list_of_speakers.can_be_speaker",
"projector.can_see",
"mediafile.can_see", "mediafile.can_see",
"motion.can_manage",
"motion.can_support",
"user.can_see"
# Missing compared with os3 and existing permissions in models.yml
"user.can_change_own_password",
"meeting.can_see_autopilot", "meeting.can_see_autopilot",
"meeting.can_see_frontpage",
# to discuss: OS3 permissions transferred to Os4 results for motion in following permissions:
"motion.can_create", "motion.can_create",
"motion.can_create_amendments", "motion.can_create_amendments",
"motion.can_support", "motion.can_support",
"projector.can_see",
"user.can_see",
"user.can_change_own_password"
], ],
"user_ids": [], "user_ids": [],

View File

@ -394,14 +394,15 @@
"admin_group_for_meeting_id": null, "admin_group_for_meeting_id": null,
"default_group_for_meeting_id": 1, "default_group_for_meeting_id": 1,
"permissions": [ "permissions": [
"agenda_item.can_see", "agenda_item.can_see_internal",
"agenda_item.can_see_internals",
"assignment.can_see", "assignment.can_see",
"meeting.can_see_frontpage", "list_of_speakers.can_see",
"projector.can_see",
"mediafile.can_see", "mediafile.can_see",
"meeting.can_see_frontpage",
"motion.can_see", "motion.can_see",
"user.can_see" "projector.can_see",
"user.can_see",
"user.can_change_own_password"
], ],
"user_ids": [], "user_ids": [],
@ -440,25 +441,18 @@
"default_group_for_meeting_id": null, "default_group_for_meeting_id": null,
"permissions": [ "permissions": [
"agenda_item.can_manage", "agenda_item.can_manage",
"agenda_item.can_see",
"agenda_item.can_see_internals",
"agenda_item.can_be_speaker",
"assignment.can_manage", "assignment.can_manage",
"assignment.can_nominate_other",
"assignment.can_nominate_self", "assignment.can_nominate_self",
"assignment.can_see", "list_of_speakers.can_be_speaker",
"projector.can_manage", "list_of_speakers.can_manage",
"meeting.can_see_frontpage",
"projector.can_see",
"tag.can_manage",
"mediafile.can_manage", "mediafile.can_manage",
"mediafile.can_see", "meeting.can_see_frontpage",
"motion.can_create", "meeting.can_see_history",
"motion.can_manage", "motion.can_manage",
"motion.can_see", "projector.can_manage",
"tag.can_manage",
"user.can_manage", "user.can_manage",
"user.can_see_extra_data", "user.can_change_own_password"
"user.can_see"
], ],
"user_ids": [], "user_ids": [],
@ -478,16 +472,16 @@
"admin_group_for_meeting_id": null, "admin_group_for_meeting_id": null,
"default_group_for_meeting_id": null, "default_group_for_meeting_id": null,
"permissions": [ "permissions": [
"agenda_item.can_see", "agenda_item.can_see_internal",
"agenda_item.can_see_internals",
"assignment.can_see", "assignment.can_see",
"meeting.can_see_frontpage", "list_of_speakers.can_see",
"projector.can_see",
"mediafile.can_see", "mediafile.can_see",
"meeting.can_see_frontpage",
"motion.can_create", "motion.can_create",
"motion.can_see", "motion.can_create_amendments",
"motion.can_support", "motion.can_support",
"users.can_see" "projector.can_see",
"user.can_see"
], ],
"user_ids": [], "user_ids": [],
@ -507,20 +501,19 @@
"admin_group_for_meeting_id": null, "admin_group_for_meeting_id": null,
"default_group_for_meeting_id": null, "default_group_for_meeting_id": null,
"permissions": [ "permissions": [
"agenda_item.can_see", "agenda_item.can_see_internal",
"agenda_item.can_see_internals",
"agenda_item.can_be_speaker",
"assignment.can_nominate_other", "assignment.can_nominate_other",
"assignment.can_nominate_self", "assignment.can_nominate_self",
"assignment.can_see", "list_of_speakers.can_be_speaker",
"meeting.can_see_frontpage",
"projector.can_see",
"mediafile.can_see", "mediafile.can_see",
"meeting.can_see_autopilot",
"meeting.can_see_frontpage",
"motion.can_create", "motion.can_create",
"motion.can_manage", "motion.can_create_amendments",
"motion.can_see",
"motion.can_support", "motion.can_support",
"user.can_see" "projector.can_see",
"user.can_see",
"user.can_change_own_password"
], ],
"user_ids": [2], "user_ids": [2],

@ -1 +1 @@
Subproject commit fe5c1f6697173d0298b2ec92d92d321736ed0bdf Subproject commit 3394779de7841449a3a7c776e74ab80d51d30ab3

@ -1 +1 @@
Subproject commit f7eb0e4cec0a0563a98066bcabc5a16b7a2e4a25 Subproject commit 58d37a5ac23d177844eadaf6d98572e028c78db8

@ -1 +1 @@
Subproject commit 949a8442db69ef5d55ed003c9d92b25a5a2a1005 Subproject commit 00e27d828068a2d94b352d01c177ad69a628acaf

@ -1 +1 @@
Subproject commit c68249eb4ad5cca1d6e80a0eb46820873eefdc50 Subproject commit 46d1cd070524f20eefc61654321656022a30405e

@ -1 +1 @@
Subproject commit 6d97a98053ec76794b28bf8adf801f4a5439f5a4 Subproject commit d0600fdab16b6b20d9eac242ef5efdef7a39a999