ag-admin/OpenSlides
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixes high cpu usage on 'projector-detail'

Browse Source 
- Also improving showing the spinner to have a slightly better UX.
This commit is contained in:
GabrielMeyer 2019-09-16 09:14:58 +02:00
parent ae55cce605
commit fe55faa884
3 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
client/src/app/site/login/components/login-mask/login-mask.component.ts
View File

@ -141,6 +141,7 @@ export class LoginMaskComponent extends BaseViewComponent implements OnInit, OnD
public async formLogin(): Promise<void> { public async formLogin(): Promise<void> {
this.loginErrorMsg = ''; this.loginErrorMsg = '';
try { try {
this.overlayService.logout(); // Ensures displaying spinner, if logging in
this.overlayService.showSpinner(this.translate.instant(this.loginMessage), true); this.overlayService.showSpinner(this.translate.instant(this.loginMessage), true);
await this.authService.login(this.loginForm.value.username, this.loginForm.value.password, () => { await this.authService.login(this.loginForm.value.username, this.loginForm.value.password, () => {
this.clearOperatorSubscription(); // We take control, not the subscription. this.clearOperatorSubscription(); // We take control, not the subscription.

11
client/src/app/site/projector/components/projector-detail/projector-detail.component.ts
View File

@ -1,11 +1,12 @@
import { CdkDragDrop, moveItemInArray } from '@angular/cdk/drag-drop'; import { CdkDragDrop, moveItemInArray } from '@angular/cdk/drag-drop';
import { Component, OnInit } from '@angular/core'; import { ChangeDetectionStrategy, ChangeDetectorRef, Component, OnInit } from '@angular/core';
import { MatDialog } from '@angular/material/dialog'; import { MatDialog } from '@angular/material/dialog';
import { MatSnackBar } from '@angular/material/snack-bar'; import { MatSnackBar } from '@angular/material/snack-bar';
import { Title } from '@angular/platform-browser'; import { Title } from '@angular/platform-browser';
import { ActivatedRoute } from '@angular/router'; import { ActivatedRoute } from '@angular/router';
import { TranslateService } from '@ngx-translate/core'; import { TranslateService } from '@ngx-translate/core';
import { timer } from 'rxjs';
import { ProjectorService } from 'app/core/core-services/projector.service'; import { ProjectorService } from 'app/core/core-services/projector.service';
import { CountdownRepositoryService } from 'app/core/repositories/projector/countdown-repository.service'; import { CountdownRepositoryService } from 'app/core/repositories/projector/countdown-repository.service';
@ -37,7 +38,8 @@ import { ViewProjector } from '../../models/view-projector';
@Component({ @Component({
selector: 'os-projector-detail', selector: 'os-projector-detail',
templateUrl: './projector-detail.component.html', templateUrl: './projector-detail.component.html',
styleUrls: ['./projector-detail.component.scss'] styleUrls: ['./projector-detail.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush
}) })
export class ProjectorDetailComponent extends BaseViewComponent implements OnInit { export class ProjectorDetailComponent extends BaseViewComponent implements OnInit {
/** /**
@ -88,7 +90,8 @@ export class ProjectorDetailComponent extends BaseViewComponent implements OnIni
private messageRepo: ProjectorMessageRepositoryService, private messageRepo: ProjectorMessageRepositoryService,
private currentListOfSpeakersSlideService: CurrentListOfSpeakersSlideService, private currentListOfSpeakersSlideService: CurrentListOfSpeakersSlideService,
private currentSpeakerChyronService: CurrentSpeakerChyronSlideService, private currentSpeakerChyronService: CurrentSpeakerChyronSlideService,
private durationService: DurationService private durationService: DurationService,
private cd: ChangeDetectorRef
) { ) {
super(titleService, translate, matSnackBar); super(titleService, translate, matSnackBar);
@ -111,6 +114,8 @@ export class ProjectorDetailComponent extends BaseViewComponent implements OnIni
} }
}); });
}); });
this.subscriptions.push(timer(0, 500).subscribe(() => this.cd.detectChanges()));
} }
/** /**

5
client/src/app/site/site.component.ts
View File

@ -103,10 +103,7 @@ export class SiteComponent extends BaseComponent implements OnInit {
private overlayService: OverlayService private overlayService: OverlayService
) { ) {
super(title, translate); super(title, translate);
overlayService.showSpinner( overlayService.showSpinner(translate.instant('Loading data. Please wait...'));
translate.instant('Loading data. Please wait...'),
!(operator.guestsEnabled && operator.isAnonymous)
);
this.operator.getViewUserObservable().subscribe(user => { this.operator.getViewUserObservable().subscribe(user => {
if (!operator.isAnonymous) { if (!operator.isAnonymous) {