From fef3cf41bb26d2142258abbe7d60602ce97318c4 Mon Sep 17 00:00:00 2001
From: Sean <sean.f.t.engelhardt@gmail.com>
Date: Wed, 13 May 2020 15:18:31 +0200
Subject: [PATCH] Hide the submitter-box in motion slide if empty

Hides the "submitter" text and corresponding boxes if they are empty
---
 .../motions/motion/motion-slide-data.ts       |  2 +-
 .../motion/motion-slide.component.html        | 72 +++++++++----------
 .../motions/motion/motion-slide.component.ts  |  9 +++
 3 files changed, 46 insertions(+), 37 deletions(-)

diff --git a/client/src/app/slides/motions/motion/motion-slide-data.ts b/client/src/app/slides/motions/motion/motion-slide-data.ts
index 1badec8c7..e60ef3080 100644
--- a/client/src/app/slides/motions/motion/motion-slide-data.ts
+++ b/client/src/app/slides/motions/motion/motion-slide-data.ts
@@ -63,7 +63,7 @@ export interface MotionSlideData {
     reason?: string;
     is_child: boolean;
     show_meta_box: boolean;
-    submitter?: string[];
+    submitters?: string[];
     recommender?: string;
     recommendation?: string;
     recommendation_extension?: string;
diff --git a/client/src/app/slides/motions/motion/motion-slide.component.html b/client/src/app/slides/motions/motion/motion-slide.component.html
index 38af8c6cf..7a594df69 100644
--- a/client/src/app/slides/motions/motion/motion-slide.component.html
+++ b/client/src/app/slides/motions/motion/motion-slide.component.html
@@ -5,7 +5,7 @@
         [ngStyle]="{ 'margin-top': projector.show_header_footer ? '144px' : '94px' }"
     >
         <!-- Submitters -->
-        <h3>{{ 'Submitters' | translate }}</h3>
+        <h3 *ngIf="data.data?.submitters?.length > 0">{{ 'Submitters' | translate }}</h3>
         <span *ngFor="let submitter of data.data.submitters; let last = last">
             {{ submitter }}<span *ngIf="!last">, </span>
         </span>
@@ -34,41 +34,41 @@
                 </span>
             </h2>
 
-            <div *ngIf="!data.data.show_meta_box">
-                <table class="metatable spacer-top-20" cellpadding="0" cellspacing="0">
-                    <!-- Submitters -->
-                    <tr>
-                        <td class="min">
-                            <b>{{ 'Submitters' | translate }}:</b>
-                        </td>
-                        <td>
-                            <span *ngFor="let submitter of data.data.submitters; let last = last">
-                                {{ submitter }}<span *ngIf="!last">, </span>
-                            </span>
-                        </td>
-                    </tr>
-                    <!-- Recommendation -->
-                    <tr *ngIf="data.data.recommendation && data.data.recommender">
-                        <td class="min">
-                            <b>{{ data.data.recommender }}:</b>
-                        </td>
-                        <td>
-                            {{ getRecommendationLabel() }}
-                        </td>
-                    </tr>
-                    <!-- recommendation referencing motions -->
-                    <tr *ngIf="data.data.recommendation_referencing_motions">
-                        <td class="min">
-                            <b>{{ 'Referring motions' | translate }}:</b>
-                        </td>
-                        <td>
-                            <span *ngFor="let titleInformation of referencingMotions; let last = last">
-                                {{ getIdentifierOrTitle(titleInformation) }}<span *ngIf="!last">,</span>
-                            </span>
-                        </td>
-                    </tr>
-                </table>
-            </div>
+            <!-- Metainfo as table -->
+            <table *ngIf="showMetaTable" class="metatable spacer-top-20" cellpadding="0" cellspacing="0">
+                <!-- Submitters -->
+                <tr *ngIf="data.data?.submitters?.length > 0">
+                    <td class="min">
+                        <b>{{ 'Submitters' | translate }}:</b>
+                    </td>
+                    <td>
+                        <span *ngFor="let submitter of data.data.submitters; let last = last">
+                            {{ submitter }}<span *ngIf="!last">, </span>
+                        </span>
+                    </td>
+                </tr>
+                <!-- Recommendation -->
+                <tr *ngIf="data.data.recommendation && data.data.recommender">
+                    <td class="min">
+                        <b>{{ data.data.recommender }}:</b>
+                    </td>
+                    <td>
+                        {{ getRecommendationLabel() }}
+                    </td>
+                </tr>
+                <!-- recommendation referencing motions -->
+                <tr *ngIf="data.data.recommendation_referencing_motions">
+                    <td class="min">
+                        <b>{{ 'Referring motions' | translate }}:</b>
+                    </td>
+                    <td>
+                        <span *ngFor="let titleInformation of referencingMotions; let last = last">
+                            {{ getIdentifierOrTitle(titleInformation) }}<span *ngIf="!last">,</span>
+                        </span>
+                    </td>
+                </tr>
+            </table>
+
         </div>
     </div>
 
diff --git a/client/src/app/slides/motions/motion/motion-slide.component.ts b/client/src/app/slides/motions/motion/motion-slide.component.ts
index 30ce6bb89..0d030af40 100644
--- a/client/src/app/slides/motions/motion/motion-slide.component.ts
+++ b/client/src/app/slides/motions/motion/motion-slide.component.ts
@@ -85,6 +85,15 @@ export class MotionSlideComponent extends BaseMotionSlideComponent<MotionSlideDa
         return this._data;
     }
 
+    public get showMetaTable(): boolean {
+        return (
+            !this.data.data.show_meta_box &&
+            (this.data.data?.submitters.length > 0 ||
+                (!!this.data.data.recommendation && !!this.data.data.recommender) ||
+                !!this.data.data.recommendation_referencing_motions)
+        );
+    }
+
     private _scroll = 0;
 
     @Input()