Commit Graph

1528 Commits

Author SHA1 Message Date
Emanuel Schütze 6f7c6036c2
Merge pull request #5280 from tsiegleauq/workflow-manager-scrolling
Enhance workflow matrix for small screens
2020-03-25 15:26:18 +01:00
Emanuel Schütze 19af02a315
Merge pull request #5278 from tsiegleauq/tinymce-in-settings-page
Manual change detection for config list
2020-03-25 15:21:41 +01:00
Sean 73fc936306 Enhance workflow matrix for small screens
makes scrolling horizontally in the workflow manager easier.
The offline banner and the voting banner will lead to unwanted results.
2020-03-25 13:01:25 +01:00
Sean c2406fcc03 Remove counting of IndexedDB and LocalStore
Mainly simplify the user counting component.

It seems that counting IndexedDB has no value anymore,
since even Firefox ESR uses IndexedDB just fine and the LS fallback
proves to be reliable enough
2020-03-25 12:18:57 +01:00
Sean 557824f5f1 Manual change detection for config list
Adds manual change detection to the config page.
Behaves better regarding "changed after checked" errors
2020-03-25 11:22:54 +01:00
Emanuel Schütze 91be76a263
Merge pull request #5276 from tsiegleauq/changeable-created-polls
Remove pseudo-disabled values in poll form
2020-03-24 16:01:17 +01:00
Emanuel Schütze eadc09dc56
Merge pull request #5271 from tsiegleauq/reset-workflow-reco
Allow empty input values in recommendation
2020-03-24 15:58:43 +01:00
Sean 6fddddd9f4 Allow empty input values in recommendation
Allows the client to send empty values as workflow
recommendation label in the workflow detail view.
This is required to remove a recommendation from a
workflow
2020-03-24 15:44:46 +01:00
FinnStutzenstein cf50295ca4 Remove Check update for others feature 2020-03-24 15:25:47 +01:00
Sean 7af2f70494 Remove pseudo-disabled values in poll form
Removed the previously disabled-looking poll options from the poll form
component.
I figguered that it would be more intuitive and closer to my
expectations if I could change the poll values even if the poll was
already created.
2020-03-24 14:22:59 +01:00
Sean 2fb372ead9
Merge pull request #5274 from tsiegleauq/untranslated-default-projector
Show translated values in projector preview
2020-03-23 17:57:09 +01:00
Sean 7d86f62e2d
Merge pull request #5273 from tsiegleauq/new-projector-reference
Create new projectors with clos reference
2020-03-23 17:31:13 +01:00
Sean d92622410f Show translated values in projector preview
Shows the translated value of "default projector"
in projector preview component.
I reomved a observable that I suppose was outdated
2020-03-23 17:28:09 +01:00
Sean 99c3afb417 Create new projectors with clos reference
New projectors will be created on a reference to the current list of
of speakers
2020-03-23 16:57:29 +01:00
Sean bf0eadebb7 Full width for LOS search user
Puts the List-Of-Speakers search user section to full width
2020-03-23 16:32:48 +01:00
Sean 5bf3dfadff Fix Shift-Enter to save poll
Fixes a bug which caused the event listener not to register
in BasePollDialog

Also hot fixes a bug in babel
2020-03-23 14:26:38 +01:00
Emanuel Schütze 5a6d2d2e42 Updated translations 2020-03-20 17:19:12 +01:00
Sean 072ec937a1 Rework assignment poll slide
Reworked assignment poll slide
and refactored the assignment poll detail table
into an own component
2020-03-20 16:53:31 +01:00
Emanuel Schütze b873dc156b
Merge pull request #5264 from tsiegleauq/bar-chart-rework
Rework Chart component
2020-03-20 13:31:20 +01:00
Sean f0e396b3a4 Rework Chart component
Cleans up the chart component
Speed up the rendering using async pipe instead of passing obserbables
Thiner bar-charts.
Fixes some bugs, some bugs are still present.
2020-03-20 10:28:59 +01:00
FinnStutzenstein 73eff81edd Catch error on invalid cache data 2020-03-19 14:00:56 +01:00
Emanuel Schütze 54dd97399e
Merge pull request #5260 from tsiegleauq/various-voting-issues
Various small fixes
2020-03-17 21:53:40 +01:00
Sean ee07e8f0ce Various small fixes
- Fix an issue in motion PDF which affected motion result percent
  values
- Fix an issue where the voting result bar chart hat a chance to show
  "null"
- Change the available votes display to count down instead of up
- Add the correct button class to the global abstain button
- Add some translatable strings
2020-03-17 21:33:46 +01:00
Sean 0ab4532ac8 Refactor usage of PollService
prevents the direct use of the abstract
"PollService".
2020-03-17 18:21:13 +01:00
Sean 3c9f6ed278 Some overall improvements
Common:
	delete unused motion poll list

Poll Create form:
	Fix ugly multi line mat hints
	(workaround, see https://github.com/angular/components/issues/5227 )

Poll List:
	Fix too tiny column size
	user_has_voted_valid (ceck icon) was not shown

Motion Poll Card:
	Enhance subtitle layout (type + state)

Assignment Poll Card:
	Open warning after clicking the hint icon

Assignment Poll Chart:
	Show Absolute values and percents in chart label

Assignment Detail:
	Add new ballot button with plus icon instead of chart icon
2020-03-17 07:24:50 +01:00
FinnStutzenstein 64f2720b1a Last changes and cleanup some todos 2020-03-17 07:24:50 +01:00
Emanuel Schütze d15c9892ed Updated translation strings and German translation. 2020-03-17 07:24:49 +01:00
Sean Engelhardt ee4c6aa0bf Even more voting refinement
Various additional refinements for a more well rounded
voting experience
2020-03-17 07:24:49 +01:00
FinnStutzenstein a05662a0f8 Show global votes in the single votes table 2020-03-17 07:24:49 +01:00
Sean Engelhardt 29a9a09bc6 Motion poll detail als slide
Refactor the code to use the motion poll detail als slide component
2020-03-17 07:24:49 +01:00
Sean Engelhardt 3c36441967 Add global no and abstain to form
Minur UI changes
Minor Chart enhancements
Server Changes
2020-03-17 07:24:48 +01:00
Sean Engelhardt 8fe5a0c9f4 Rework assignment voting
- Remove "assignments.can_manage_polls" permission
- Let the client handle some user errors
- Add a send button to manually submit polls
- Show a hint that the user already submitted a vote
  - will not (and should not) work for non-nominal voting
- submitting a vote cannot be changed anymore
  - user will have to confirm sending
- enable deselecting YNA-votings
- nomainal voting will behace the same as non nominal voting
- submitting empty votes should be possible

Perhaps server side adjustments might still be required
2020-03-17 07:24:48 +01:00
Sean Engelhardt 61b7731073 Enhance charts and tables for assignments
Also some various improvements
2020-03-17 07:24:48 +01:00
Sean Engelhardt 53b9ce73f2 Enhance table layouts
Enhance the result table layout for assignments
2020-03-17 07:24:47 +01:00
Joshua Sangmeister 9d7028ea5f now filters percent bases correctly 2020-03-17 07:24:47 +01:00
Joshua Sangmeister 72678770bb table update on pseudoanonymize, view base classes for votes and
options, renaming for assignment percent bases
2020-03-17 07:24:46 +01:00
Emanuel Schütze 2d13519c35 Updated voting strings for translation 2020-03-17 07:24:46 +01:00
Joshua Sangmeister e72bcc1eaf removed default group from 'entitled to vote' selection 2020-03-17 07:24:46 +01:00
Sean Engelhardt 97a5bb4aa6 Cleanup Voting, enhance UI and UX
removed certain unnecesary fields
cleaned up a lot of code
redone some of the UI
some database and server adjustments
2020-03-17 07:24:45 +01:00
Joshua Sangmeister 7598fc5367 Fixed the numbering of assignment candidates for projector and PDF 2020-03-17 07:24:45 +01:00
Joshua Sangmeister b48ca8c434 added chart projection for polls 2020-03-17 07:24:45 +01:00
Sean Engelhardt 6ba0d0c5e6 Client side changes 2020-03-17 07:24:44 +01:00
FinnStutzenstein 0b37c5a857 WIP: Partial requests 2020-03-17 07:24:44 +01:00
Joshua Sangmeister d4599a435b added virtual scrolling for single votes tables 2020-03-17 07:24:44 +01:00
Sean Engelhardt 93dc78c7d6 Result PDF for Voting
- Add result PDF for Motion and Assignments
- Add "getPercentBase" for Assignment
2020-03-17 07:24:44 +01:00
Sean Engelhardt 6044c63c28 Enhance Assignment Voting
- repaired the PDF Service for ballots
- fixed some permission errors
- analog voting has no "started" option anymore
- more-link as button
- named voting has a progress bar
- Shows the poll type for eVoting
- Moves and declutters meta info
- Enhance the grid and the layout in detail view
- declutter and enhance the dot-menus
- some other layout changes
- remove breadcrumbs in assignment detail
- other cleanups refinements
- Voting in Assignment over instead of forms
(requires more server changes)
2020-03-17 07:24:43 +01:00
Sean 524a97cdcc Enhance voting
- cleaned up a lot of code
- removed required majotiry from forms
- renamed verbose "Majority method" to "Required majority"
- poll-progress-bar only counts present user
- enhanced motion poll tile chart layout
- removed PercentBase.Votes
- added pollPercentBase pipe
- Show the voting percent next to chart in motion detail
- change the head bar to "Voting is open"
  and "Ballot is open"
- merged the voting configs to their corresponding config-categories
- re-add ballot paper configs
- Add "more" button to motion polls
- Adjusted the motion results table
  - Hide entries without information
  - Show icons for Y N A
  - Show percentage next to Y N A
2020-03-17 07:24:43 +01:00
GabrielMeyer 6c1317e25f Fixes labelling for charts 2020-03-17 07:24:43 +01:00
GabrielMeyer 294b75c320 Replaces the mat-table with a classic table 2020-03-17 07:24:42 +01:00
GabrielMeyer 09b0d19de0 Fixes permissions for assignments
- There were some fields that user could see/click/handle, although the user has not the correct permission for the action
2020-03-17 07:24:42 +01:00