wtf-eg/handbuch-gen
Archived
1
0
Fork 2
forked from gulliver/rtfm
Code Issues Pull Requests Projects Releases Wiki Activity

Why are files of the HTML sources removed? #19

New Issue
Closed
opened 2022-12-15 15:00:47 +01:00 by dancingCycle · 7 comments
dancingCycle commented 2022-12-15 15:00:47 +01:00
Member
Copy Link

Hi folks,
Can anyone share with me, why the following files are removed from the HTML sources before they are bundled?

Makefile Line 29 in 222ad0244b
rm build/singlehtml/_static/base-stemmer.js

Cheers!

Hi folks, Can anyone share with me, why the following files are removed from the HTML sources before they are bundled? https://git.wtf-eg.de/wtf-eg/handbuch-gen/src/commit/222ad0244b4de5b0a70c9fe79a359422f39b40ec/Makefile#L29 Cheers!
Brain commented 2022-12-15 19:07:26 +01:00
Member
Copy Link

I remember that I also wondered why they were removed, but they did not seem to be missing when browsing the HTML version. But probably @gulliver knows more.

I remember that I also wondered why they were removed, but they did not seem to be missing when browsing the HTML version. But probably @gulliver knows more.
gulliver commented 2022-12-15 19:21:52 +01:00
Owner
Copy Link

see 1074512e25.

seems to be an optimisation for size of html-output.

see https://git.wtf-eg.de/wtf-eg/handbuch-gen/commit/1074512e258de1aed638b4f4a7345481a464b3a6. seems to be an optimisation for size of html-output.
dancingCycle commented 2022-12-15 20:14:02 +01:00
Author
Member
Copy Link

But @gulliver , How do you know which files to remove from the build without breaking the HTML? Did you learn the dependencies by heart to tell useful und useless stuff apart?

Cheers!

But @gulliver , How do you know which files to remove from the build without breaking the HTML? Did you learn the dependencies by heart to tell useful und useless stuff apart? Cheers!
gulliver commented 2022-12-15 20:15:10 +01:00
Owner
Copy Link

please ask muli for that, he did that optimisation, see referenced commit in my comment.

please ask muli for that, he did that optimisation, see referenced commit in my comment.
dancingCycle commented 2022-12-18 20:27:25 +01:00
Author
Member
Copy Link

@muli,
May I ask you to share your 2 Cents with us why some source files are deleted after generation of the HTML Hanbuch variant?

Cheers!

@muli, May I ask you to share your 2 Cents with us why some source files are deleted after generation of the HTML Hanbuch variant? Cheers!
muli was assigned by gulliver 2022-12-19 11:01:57 +01:00
muli commented 2022-12-19 22:44:07 +01:00
Member
Copy Link

I don't remeber exactly because it's over a year ago that I laid hands on the handbook but I've got the old version still lying around. As far as I see the main content is rendered into a single index.html file. I guess I looked at the <head> of that file and removed all files that were not referenced there.

As @gulliver mentioned we tried to save space back then so I removed what I could. Biggest chunk were the fonts and if removing these files really made a nesseccary impact may be debatable (not sure how big the pngs are though).

I don't remeber exactly because it's over a year ago that I laid hands on the handbook but I've got the old version still lying around. As far as I see the main content is rendered into a single `index.html` file. I guess I looked at the `<head>` of that file and removed all files that were not referenced there. As @gulliver mentioned we tried to save space back then so I removed what I could. Biggest chunk were the fonts and if removing these files really made a nesseccary impact may be debatable (not sure how big the pngs are though).
dancingCycle commented 2023-01-10 13:21:12 +01:00
Author
Member
Copy Link

Hi @muli ,
Thank you so much for clarification and documenting your thoughts here for future use.

Cheers!

Hi @muli , Thank you so much for clarification and documenting your thoughts here for future use. Cheers!
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
muli
4 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: wtf-eg/handbuch-gen#19
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?