ag-admin/OpenSlides
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Bugfix: change detection for change recommendations

Browse Source
This commit is contained in:
Tobias Hößl 2018-12-16 14:41:32 +01:00
parent f15cb4d42e
commit 058d87eb77
No known key found for this signature in database
GPG Key ID: 1D780C7599C2D2A2
2 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
client/src/app/site/motions/components/motion-detail-diff/motion-detail-diff.component.html
View File

@ -111,7 +111,7 @@
<button <button
type="button" type="button"
mat-menu-item mat-menu-item
[disabled]="hasCollissions(change)" [disabled]="hasCollissions(change, changes)"
(click)="setAcceptanceValue(change, 'accepted')" (click)="setAcceptanceValue(change, 'accepted')"
> >
<mat-icon>thumb_up</mat-icon> <mat-icon>thumb_up</mat-icon>
@ -121,7 +121,7 @@
<button <button
type="button" type="button"
mat-menu-item mat-menu-item
[disabled]="hasCollissions(change)" [disabled]="hasCollissions(change, changes)"
(click)="setAcceptanceValue(change, 'rejected')" (click)="setAcceptanceValue(change, 'rejected')"
> >
<mat-icon>thumb_down</mat-icon> <mat-icon>thumb_down</mat-icon>

12
client/src/app/site/motions/components/motion-detail-diff/motion-detail-diff.component.ts
View File

@ -101,11 +101,13 @@ export class MotionDetailDiffComponent extends BaseViewComponent implements Afte
return ( return (
changes.filter((otherChange: ViewUnifiedChange) => { changes.filter((otherChange: ViewUnifiedChange) => {
return ( return (
(otherChange.getChangeId() === change.getChangeId() && otherChange.getChangeId() !== change.getChangeId() &&
(otherChange.getLineFrom() >= change.getLineFrom() && ((otherChange.getLineFrom() >= change.getLineFrom() &&
otherChange.getLineFrom() < change.getLineTo())) || otherChange.getLineFrom() < change.getLineTo()) ||
(otherChange.getLineTo() > change.getLineFrom() && otherChange.getLineTo() <= change.getLineTo()) || (otherChange.getLineTo() > change.getLineFrom() &&
(otherChange.getLineFrom() < change.getLineFrom() && otherChange.getLineTo() > change.getLineTo()) otherChange.getLineTo() <= change.getLineTo()) ||
(otherChange.getLineFrom() < change.getLineFrom() &&
otherChange.getLineTo() > change.getLineTo()))
); );
}).length > 0 }).length > 0
); );