Commit Graph

1570 Commits

Author SHA1 Message Date
FinnStutzenstein
cf50295ca4 Remove Check update for others feature 2020-03-24 15:25:47 +01:00
Sean
7af2f70494 Remove pseudo-disabled values in poll form
Removed the previously disabled-looking poll options from the poll form
component.
I figguered that it would be more intuitive and closer to my
expectations if I could change the poll values even if the poll was
already created.
2020-03-24 14:22:59 +01:00
Sean
2fb372ead9
Merge pull request #5274 from tsiegleauq/untranslated-default-projector
Show translated values in projector preview
2020-03-23 17:57:09 +01:00
Sean
7d86f62e2d
Merge pull request #5273 from tsiegleauq/new-projector-reference
Create new projectors with clos reference
2020-03-23 17:31:13 +01:00
Sean
d92622410f Show translated values in projector preview
Shows the translated value of "default projector"
in projector preview component.
I reomved a observable that I suppose was outdated
2020-03-23 17:28:09 +01:00
Sean
99c3afb417 Create new projectors with clos reference
New projectors will be created on a reference to the current list of
of speakers
2020-03-23 16:57:29 +01:00
Sean
bf0eadebb7 Full width for LOS search user
Puts the List-Of-Speakers search user section to full width
2020-03-23 16:32:48 +01:00
Sean
5bf3dfadff Fix Shift-Enter to save poll
Fixes a bug which caused the event listener not to register
in BasePollDialog

Also hot fixes a bug in babel
2020-03-23 14:26:38 +01:00
Emanuel Schütze
5a6d2d2e42 Updated translations 2020-03-20 17:19:12 +01:00
Sean
072ec937a1 Rework assignment poll slide
Reworked assignment poll slide
and refactored the assignment poll detail table
into an own component
2020-03-20 16:53:31 +01:00
Emanuel Schütze
b873dc156b
Merge pull request #5264 from tsiegleauq/bar-chart-rework
Rework Chart component
2020-03-20 13:31:20 +01:00
Sean
f0e396b3a4 Rework Chart component
Cleans up the chart component
Speed up the rendering using async pipe instead of passing obserbables
Thiner bar-charts.
Fixes some bugs, some bugs are still present.
2020-03-20 10:28:59 +01:00
FinnStutzenstein
73eff81edd Catch error on invalid cache data 2020-03-19 14:00:56 +01:00
Emanuel Schütze
54dd97399e
Merge pull request #5260 from tsiegleauq/various-voting-issues
Various small fixes
2020-03-17 21:53:40 +01:00
Sean
ee07e8f0ce Various small fixes
- Fix an issue in motion PDF which affected motion result percent
  values
- Fix an issue where the voting result bar chart hat a chance to show
  "null"
- Change the available votes display to count down instead of up
- Add the correct button class to the global abstain button
- Add some translatable strings
2020-03-17 21:33:46 +01:00
Sean
0ab4532ac8 Refactor usage of PollService
prevents the direct use of the abstract
"PollService".
2020-03-17 18:21:13 +01:00
Sean
3c9f6ed278 Some overall improvements
Common:
	delete unused motion poll list

Poll Create form:
	Fix ugly multi line mat hints
	(workaround, see https://github.com/angular/components/issues/5227 )

Poll List:
	Fix too tiny column size
	user_has_voted_valid (ceck icon) was not shown

Motion Poll Card:
	Enhance subtitle layout (type + state)

Assignment Poll Card:
	Open warning after clicking the hint icon

Assignment Poll Chart:
	Show Absolute values and percents in chart label

Assignment Detail:
	Add new ballot button with plus icon instead of chart icon
2020-03-17 07:24:50 +01:00
FinnStutzenstein
64f2720b1a Last changes and cleanup some todos 2020-03-17 07:24:50 +01:00
Emanuel Schütze
d15c9892ed Updated translation strings and German translation. 2020-03-17 07:24:49 +01:00
Sean Engelhardt
ee4c6aa0bf Even more voting refinement
Various additional refinements for a more well rounded
voting experience
2020-03-17 07:24:49 +01:00
FinnStutzenstein
a05662a0f8 Show global votes in the single votes table 2020-03-17 07:24:49 +01:00
Sean Engelhardt
29a9a09bc6 Motion poll detail als slide
Refactor the code to use the motion poll detail als slide component
2020-03-17 07:24:49 +01:00
Sean Engelhardt
3c36441967 Add global no and abstain to form
Minur UI changes
Minor Chart enhancements
Server Changes
2020-03-17 07:24:48 +01:00
Sean Engelhardt
8fe5a0c9f4 Rework assignment voting
- Remove "assignments.can_manage_polls" permission
- Let the client handle some user errors
- Add a send button to manually submit polls
- Show a hint that the user already submitted a vote
  - will not (and should not) work for non-nominal voting
- submitting a vote cannot be changed anymore
  - user will have to confirm sending
- enable deselecting YNA-votings
- nomainal voting will behace the same as non nominal voting
- submitting empty votes should be possible

Perhaps server side adjustments might still be required
2020-03-17 07:24:48 +01:00
Sean Engelhardt
61b7731073 Enhance charts and tables for assignments
Also some various improvements
2020-03-17 07:24:48 +01:00
Sean Engelhardt
53b9ce73f2 Enhance table layouts
Enhance the result table layout for assignments
2020-03-17 07:24:47 +01:00
Joshua Sangmeister
9d7028ea5f now filters percent bases correctly 2020-03-17 07:24:47 +01:00
Joshua Sangmeister
72678770bb table update on pseudoanonymize, view base classes for votes and
options, renaming for assignment percent bases
2020-03-17 07:24:46 +01:00
Emanuel Schütze
2d13519c35 Updated voting strings for translation 2020-03-17 07:24:46 +01:00
Joshua Sangmeister
e72bcc1eaf removed default group from 'entitled to vote' selection 2020-03-17 07:24:46 +01:00
Sean Engelhardt
97a5bb4aa6 Cleanup Voting, enhance UI and UX
removed certain unnecesary fields
cleaned up a lot of code
redone some of the UI
some database and server adjustments
2020-03-17 07:24:45 +01:00
Joshua Sangmeister
7598fc5367 Fixed the numbering of assignment candidates for projector and PDF 2020-03-17 07:24:45 +01:00
Joshua Sangmeister
b48ca8c434 added chart projection for polls 2020-03-17 07:24:45 +01:00
Sean Engelhardt
6ba0d0c5e6 Client side changes 2020-03-17 07:24:44 +01:00
FinnStutzenstein
0b37c5a857 WIP: Partial requests 2020-03-17 07:24:44 +01:00
Joshua Sangmeister
d4599a435b added virtual scrolling for single votes tables 2020-03-17 07:24:44 +01:00
Sean Engelhardt
93dc78c7d6 Result PDF for Voting
- Add result PDF for Motion and Assignments
- Add "getPercentBase" for Assignment
2020-03-17 07:24:44 +01:00
Sean Engelhardt
6044c63c28 Enhance Assignment Voting
- repaired the PDF Service for ballots
- fixed some permission errors
- analog voting has no "started" option anymore
- more-link as button
- named voting has a progress bar
- Shows the poll type for eVoting
- Moves and declutters meta info
- Enhance the grid and the layout in detail view
- declutter and enhance the dot-menus
- some other layout changes
- remove breadcrumbs in assignment detail
- other cleanups refinements
- Voting in Assignment over instead of forms
(requires more server changes)
2020-03-17 07:24:43 +01:00
Sean
524a97cdcc Enhance voting
- cleaned up a lot of code
- removed required majotiry from forms
- renamed verbose "Majority method" to "Required majority"
- poll-progress-bar only counts present user
- enhanced motion poll tile chart layout
- removed PercentBase.Votes
- added pollPercentBase pipe
- Show the voting percent next to chart in motion detail
- change the head bar to "Voting is open"
  and "Ballot is open"
- merged the voting configs to their corresponding config-categories
- re-add ballot paper configs
- Add "more" button to motion polls
- Adjusted the motion results table
  - Hide entries without information
  - Show icons for Y N A
  - Show percentage next to Y N A
2020-03-17 07:24:43 +01:00
GabrielMeyer
6c1317e25f Fixes labelling for charts 2020-03-17 07:24:43 +01:00
GabrielMeyer
294b75c320 Replaces the mat-table with a classic table 2020-03-17 07:24:42 +01:00
GabrielMeyer
09b0d19de0 Fixes permissions for assignments
- There were some fields that user could see/click/handle, although the user has not the correct permission for the action
2020-03-17 07:24:42 +01:00
Joshua Sangmeister
df1047fc76 various improvements for polls 2020-03-17 07:24:42 +01:00
Joshua Sangmeister
bc54a6eb46 improved 'votes' pollmethod 2020-03-17 07:24:42 +01:00
Joshua Sangmeister
1de73d5701 improved shared poll list 2020-03-17 07:24:41 +01:00
GabrielMeyer
a0c3a28456 Adds a chart for assignment-poll-detail 2020-03-17 07:24:41 +01:00
GabrielMeyer
c46369c6a7 Reworks the banner showing if there are polls
- Makes it higher on mobilephones
- Changes title, if there is only one poll
2020-03-17 07:24:41 +01:00
Joshua Sangmeister
b16afaa285 number poll candidates depending on setting 2020-03-17 07:24:40 +01:00
FinnStutzenstein
e2585fb757 Projector for polls: Server, client structure and data modeling 2020-03-17 07:24:40 +01:00
Sean Engelhardt
84a39ccb62 More voting UI improvements
For Motion poll:
- Overworked how motion poll chart displays the legend
- Added the vote counter to the motion detail
- Added a progress bar to the vote counter
- Fixed some perm errors with the chart
- Show a "Singe Votes" link as button for published named polls
- Replace the edit-button with a dot-menu
  - Having project, Edit, PDF and Delete

For Motion Poll detail:
- enhance search panel
- Remove the breadcrumbs
- Remove the vote counter
- Enhanced the single-vote grid, table and filter bar
- Enhance how the poll state enum was checkend

For the Motion Poll Create/Update Form:
- Remove the selection of poll-methode (whenever possible)
- only show "publish imediately" during creation
2020-03-17 07:24:40 +01:00
Joshua Sangmeister
682db96b7c added vote per user table and progress for polls
added update for options after stopping a poll
2020-03-17 07:24:39 +01:00
Sean
604df9d48b Enhance voting ux 2020-03-17 07:24:39 +01:00
FinnStutzenstein
7ab5346198 disable caching for reverse relations 2020-03-17 07:24:39 +01:00
GabrielMeyer
fff1f15b6c Polls for motions and assignments
- Adds charts to assignments
- Creates base-classes for polls
2020-03-17 07:24:38 +01:00
GabrielMeyer
96aa3b0084 Adds the chart and dialog for analog voting 2020-03-17 07:24:38 +01:00
jsangmeister
90b04366b5 added option to number poll cadidates 2020-03-17 07:24:37 +01:00
GabrielMeyer
8d77c0495b Initial polling 2020-03-17 07:24:36 +01:00
FinnStutzenstein
1246dd54ad majorities in polls 2020-03-17 07:24:35 +01:00
FinnStutzenstein
ce171980e8 Relations in the client 2020-03-17 07:24:34 +01:00
FinnStutzenstein
ced40cab74 Initial work for supporting voting 2020-03-17 07:24:34 +01:00
Emanuel Schütze
4d4697eee0
Merge pull request #5246 from jsangmeister/motion-block-check
Added an indicator if all motions of a block are finished
2020-03-12 21:24:01 +01:00
Joshua Sangmeister
aa46922c8b added an indicator if all motions of a block are finished 2020-03-12 16:21:41 +01:00
Emanuel Schütze
ec17376e8e
Merge pull request #5245 from jsangmeister/amendment-navigation
Added navigation between amendments when not shown in main list
2020-03-12 15:39:26 +01:00
Joshua Sangmeister
7acf2157fa added navigation between amendments when not shown in main list 2020-03-12 11:53:29 +01:00
Joshua Sangmeister
70fc5a69ab fix the error when creating a final print template after a title change recommendation 2020-03-12 09:39:56 +01:00
GabrielMeyer
13de88c136 Updates dark-theme 2020-02-26 13:39:07 +01:00
Sean
98146a29c7
Merge pull request #5227 from FinnStutzenstein/projectorLoadChildrenCallback
Use LoadChildrenCallback instead of deprecated NgModuleFactoryLoader
2020-02-25 10:50:19 +01:00
FinnStutzenstein
7204d59d66 [WIP] External postgres as mediafile store 2020-02-17 14:38:32 +01:00
FinnStutzenstein
76bd184ff4 Use LoadChildrenCallback instead of deprecated NgModuleFactoryLoader 2020-02-17 14:38:02 +01:00
Sean Engelhardt
2236f63fe9 Hide print-template button
Hides the "create final print template" button if
a print template exists.
Should be more user friendly and less dangerous to use.
2020-01-30 13:13:52 +01:00
Emanuel Schütze
0267b0cb42 Updated German translation 2020-01-30 09:35:57 +01:00
Emanuel Schütze
2ac01a5ea3
Merge pull request #5193 from tsiegleauq/final-version-without-reco
Allow final versions without change reco
2020-01-30 09:31:36 +01:00
Sean
a51720e18b
Merge pull request #5191 from tsiegleauq/pdf-catalog-optional-page-breaks
Add option to export motions with pagebreaks
2020-01-29 16:33:37 +01:00
Sean Engelhardt
27e8301131 Allow final versions without change reco
Alters the creation process of final versions
in a way one can create them independantly
of change recomendations.
2020-01-29 16:28:36 +01:00
Sean Engelhardt
407a430419 Add option to export motions with pagebreaks
Adds an option to the PDF motion list exporter
that allows users to explicitly enforce or prevent
page breaks before a new motion was printed.

The option is enabled by default
2020-01-29 15:18:56 +01:00
Emanuel Schütze
a6bdaedff1
Merge pull request #5192 from tsiegleauq/reco-and-state-in-pdf-toc
Show final state in Motion PDF toc
2020-01-29 15:09:50 +01:00
Sean Engelhardt
a161bca028 Show final state in Motion PDF toc
Renamed the option
"Show submitters and recommendation in table of contents"
to
"Show submitters and recommendation/state in table of contents"
If the option is selected, the PDF-TOC for motions will print
the name of the current state (if final) rather than the
current recomendation
2020-01-29 14:28:56 +01:00
Sean Engelhardt
6f114d0072 Fix flat map
Fixes a bug which was breaking flatMap
2020-01-29 12:47:42 +01:00
Sean
8012bfbfc0
Merge pull request #5187 from tsiegleauq/ngrid-updates
Update ngrid, redefine prototypes of datatypes
2020-01-23 15:10:18 +01:00
Sean Engelhardt
faf8004280 Use amendmend wizzard for amendments
Allows paragraph based amendments for other paragraph based
amendments.
Amendments to amendments will be amended to the main motion,
but will contain all the changes to the amendments they were
refering to

solves #5171
2020-01-23 12:46:19 +01:00
Sean Engelhardt
c2ad39a2c5 Update ngrid, redefine prototypes of datatypes
Updates ngrid to the latest version
Use Object.defineProperty instead of
Number.prototype to safer extend native datatypes
2020-01-23 12:38:46 +01:00
Sean Engelhardt
ff271748d7 Reenable Service Worker
Fixes a regression that was preventing the service worker from loading
2019-12-17 10:00:57 +01:00
Emanuel Schütze
e45d3aa360
Merge pull request #5164 from emanuelschuetze/translation-20191213
Updated CS translations
2019-12-13 09:33:56 +01:00
Emanuel Schütze
3bf588c013 Updated CS translations 2019-12-13 09:17:58 +01:00
Sean Engelhardt
f64a855b50 Fix order of comments in motion detail
Fixes an error where the order of comment section in
the motion comment section component was wrong
2019-12-12 12:10:56 +01:00
Emanuel Schütze
bb41125bd1
Merge pull request #5162 from tsiegleauq/search-value-selector-for-states
Fix untranslated searchable values
2019-12-10 17:00:29 +01:00
Sean Engelhardt
1e45153c0a Fix untranslated searchable values
Fixes a bug where the search value selector was not always filtering
for translated values.
Uses getTitle() in SearchValue selector rather than toString,
to allow enhance compatibility with custom values
2019-12-10 16:46:59 +01:00
Sean Engelhardt
af9a62abbb Fix null values in recommencation label
Fixes an issue that was showing empty values when setting
a recommendation
2019-12-10 10:56:21 +01:00
Emanuel Schütze
1bababd8c1 Updated translations (DE, CS, RU) 2019-12-09 17:30:48 +01:00
Emanuel Schütze
9e81e6145f Rename config option to show meta box below title on projector. 2019-12-09 16:32:46 +01:00
Emanuel Schütze
53ebbabc9b
Merge pull request #5157 from tsiegleauq/no-amendment
Add more motion filter options
2019-12-09 15:44:07 +01:00
Sean Engelhardt
c9cf99d0e4 Add leftover changes for 3.1
Adds various changes for a more complete 3.1 release

- cleaner "current slide" description in projector detail (grid with ellipsis)
- show the previously projected slides as ordered lists under the accordion
- fix a bug where everyone could access the projection manage view (although it was unfunctional without the correct permissions)
- assignment list now uses the correct ellipsis
- fixes a bug where the lable "list of speakers" was not translated on the projector slide
- Show a lock on the "list of speaker"-slide if it has been closed
- enable dialog tests that have previously been disabled
2019-12-09 15:00:32 +01:00
Sean Engelhardt
d17ad04b6c Add more motion filter options
Adds a motion filter option for motions which have no
amendments and are no amendments
2019-12-09 14:24:05 +01:00
Sean
01b626d3e7 Scroll to previous offset rather than index
Changes some auto scrolling behavior in our virtual scrolling tables.
Save the scroll offset before any navigation attempt, rather than
saving the index on click.
Should work for every possible navigation action.
2019-12-06 13:50:14 +01:00
Sean Engelhardt
ae62fd69f5 Add event description to PDF
Fixes a bug where the event name was printed twice in the PDF header
2019-12-04 15:37:38 +01:00
Sean
93d9e6b169
Merge pull request #5151 from tsiegleauq/offline-spinner-issue
Consider offline during update checks
2019-12-02 17:06:26 +01:00
Emanuel Schütze
b506735cfe
Merge pull request #5148 from tsiegleauq/manual-cd-workflow-detail
Add manual cd for workflow detail
2019-12-02 17:05:49 +01:00
Sean Engelhardt
a6891ef8e1 Consider offline during update checks
Hides the spinner if the update checks fail cause the server is
unreachable

use new cleansup the code a little
2019-12-02 16:55:46 +01:00
Sean Engelhardt
dd272c823f Add manual cd for workflow detail 2019-12-02 16:35:51 +01:00
Emanuel Schütze
2c120dd67c
Merge pull request #5150 from tsiegleauq/no-export-inline-numbers
Remove option for inline line number PDF
2019-12-02 15:44:42 +01:00