kompetenzinventar/ki-backend
5
7
Fork 4
Code Issues Pull Requests 11 Packages Projects Releases 2 Activity

Komplettes Profil zurückgeben #19

Merged
weeman merged 3 commits from feature-return-entire-profile into main 2021-06-27 09:44:59 +02:00
Conversation 4 Commits 3 Files Changed 10 +237 -78
weeman commented 2021-06-26 12:17:29 +02:00
Owner
Copy Link

closes #11

closes #11
weeman added 3 commits 2021-06-26 12:17:30 +02:00
seed entire profile ace1b1ed85
add yapf config file 3bd9b03002
return full profile response
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
fc01bec163
weeman requested review from frlan 2021-06-26 12:17:35 +02:00
weeman requested review from scammo 2021-06-26 12:17:35 +02:00
weeman reviewed 2021-06-26 12:18:54 +02:00
.style.yapf
@@ -0,0 +1,3 @@
[style]
based_on_style = pep8
allow_split_before_dict_value = 0
weeman commented 2021-06-26 12:18:54 +02:00
Author
Owner
Copy Link

Das hat mich verrückt gemacht. Ich würde das ausschalten wollen.

Das hat mich verrückt gemacht. Ich würde das ausschalten wollen.
weeman reviewed 2021-06-26 12:19:25 +02:00
README.md
@@ -24,3 +24,3 @@
pipenv shell
flask db upgrade
flask seed
flask seed --dev
weeman commented 2021-06-26 12:19:25 +02:00
Author
Owner
Copy Link

Die Idee: --dev legt mehr an, wie zum Beispiel den Peter.
Damit man beim Entwickeln direkt loslegen kann.

Die Idee: `--dev` legt mehr an, wie zum Beispiel den Peter. Damit man beim Entwickeln direkt loslegen kann.
weeman reviewed 2021-06-26 12:20:13 +02:00
ki/test/test_profile_endpoint.py
@@ -89,3 +75,3 @@
self.assertEqual(
self.assertDictEqual(
response.json, {
"profile": {
weeman commented 2021-06-26 12:20:13 +02:00
Author
Owner
Copy Link

@scammo das ist ein Beispiel für eine vollständige Profil-Response, wie sie dann über die API rausgeht.

@scammo das ist ein Beispiel für eine vollständige Profil-Response, wie sie dann über die API rausgeht.
frlan approved these changes 2021-06-26 20:58:09 +02:00
frlan left a comment
Owner
Copy Link

LGTM

LGTM
weeman merged commit d10706e301 into main 2021-06-27 09:44:59 +02:00
weeman deleted branch feature-return-entire-profile 2021-06-27 09:45:03 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
scammo
frlan
Labels
Clear labels
bug
Something is not working
doing
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
ready
Bereit für Release
review
security
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Brain drone-bot frlan gulliver igk Lasagne marei Nikolai renovate-bot scammo srsh weeman
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kompetenzinventar/ki-backend#19
No description provided.
Delete Branch "feature-return-entire-profile"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?