kompetenzinventar/ki-backend
5
6
Fork 4
Code Issues Pull Requests 13 Packages Projects Releases 1 Activity

Profilsuche nach Nickname #41

Merged
weeman merged 1 commits from feature-nickname-search into main 2021-07-26 19:40:34 +02:00
Conversation 1 Commits 1 Files Changed 7 +66 -31
weeman commented 2021-07-12 21:15:35 +02:00
Owner
Copy Link
  • Suche nach Nickname
  • Den Test mal richtig gemacht - lol

closes #37

- Suche nach Nickname - Den Test mal richtig gemacht - lol closes #37
weeman added 1 commit 2021-07-12 21:15:35 +02:00
add search by nick
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
f2ea02f7e3
frlan reviewed 2021-07-26 18:26:59 +02:00
ki/handlers/find_profiles.py Outdated
@ -22,0 +22,4 @@
if "nickname" in request.args:
nickname = request.args.get("nickname")
query = query.filter(Profile.nickname.like(f"%{nickname}%"))
frlan commented 2021-07-26 18:26:59 +02:00
Owner
Copy Link

Possible SQL injection? Needs to be double checked

Possible SQL injection? Needs to be double checked
weeman commented 2021-07-26 19:27:54 +02:00
Author
Owner
Copy Link

Laut Doku escaped SQLAlchemy das automagisch.
Aber lass einen Test reinpacken.

Laut Doku escaped SQLAlchemy das automagisch. Aber lass einen Test reinpacken.
weeman commented 2021-07-26 19:31:47 +02:00
Author
Owner
Copy Link

Test eingefügt

Test eingefügt
weeman marked this conversation as resolved
weeman added 1 commit 2021-07-26 19:30:58 +02:00
add sql special chars test
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
840cf8830d
weeman force-pushed feature-nickname-search from 840cf8830d to 76e95311f0 2021-07-26 19:31:36 +02:00 Compare
weeman merged commit ea57f326b7 into main 2021-07-26 19:40:33 +02:00
weeman deleted branch feature-nickname-search 2021-07-26 19:40:38 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
doing
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
ready
Bereit für Release
review
security
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Brain drone-bot frlan gulliver igk Lasagne marei Nikolai renovate-bot scammo srsh weeman
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kompetenzinventar/ki-backend#41
No description provided.
Delete Branch "feature-nickname-search"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?